linux-kernel - Re: [PATCH v2 2/2] mfd: cros_ec: Add usbpd-notify to usbpd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e64cc02a-ca4e-53e1-c0b6-4d38c7e95192@collabora.com>
Date:   Fri, 20 Dec 2019 09:52:41 +0100
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Prashant Malani <pmalani@...omium.org>, groeck@...omium.org,
        bleung@...omium.org, lee.jones@...aro.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] mfd: cros_ec: Add usbpd-notify to usbpd_charger

Hi Prashant,

Please try to maintain versions and changelog consistently. I.e I see v2 here
but I guess you only send this patch not the full series, also I see that you
send v3 before this?

In general you should send the full series on every version and maintain a full
changelog.

I'd like to see v4 including all the series so it's clear from were we pick up
the patches.

On 20/12/19 1:49, Prashant Malani wrote:
> Add the cros-usbpd-notify driver as a cell for the cros_usbpd_charger
> subdevice on non-ACPI platforms.
> 
> This driver allows other cros-ec devices to receive PD event
> notifications from the Chrome OS Embedded Controller (EC) via a
> notification chain.
> 
> Signed-off-by: Prashant Malani <pmalani@...omium.org>

For v4 you can include:

Acked-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>

Thanks,
 Enric

> ---
> 
> Changes in v2:
> - Removed auto-generated Change-Id.
> 
>  drivers/mfd/cros_ec_dev.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
> index c4b977a5dd966..1dde480f35b93 100644
> --- a/drivers/mfd/cros_ec_dev.c
> +++ b/drivers/mfd/cros_ec_dev.c
> @@ -85,6 +85,9 @@ static const struct mfd_cell cros_ec_sensorhub_cells[] = {
>  static const struct mfd_cell cros_usbpd_charger_cells[] = {
>  	{ .name = "cros-usbpd-charger", },
>  	{ .name = "cros-usbpd-logger", },
> +#ifndef CONFIG_ACPI
> +	{ .name = "cros-usbpd-notify", },
> +#endif
>  };
>  
>  static const struct cros_feature_to_cells cros_subdevices[] = {
>