linux-kernel - RE: [RESEND PATCH v1 14/15] dt-bindings: phy: phy-cadence-torrent: Add platform dependent compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR07MB5110503F5B2B0A2B9E3E02F5D22D0@BYAPR07MB5110.namprd07.prod.outlook.com>
Date:   Fri, 20 Dec 2019 09:43:37 +0000
From:   Yuti Suresh Amonkar <yamonkar@...ence.com>
To:     "robh@...nel.org" <robh@...nel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "kishon@...com" <kishon@...com>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "jsarha@...com" <jsarha@...com>,
        "tomi.valkeinen@...com" <tomi.valkeinen@...com>,
        "praneeth@...com" <praneeth@...com>,
        Milind Parab <mparab@...ence.com>,
        Swapnil Kashinath Jakhade <sjakhade@...ence.com>
Subject: RE: [RESEND PATCH v1 14/15] dt-bindings: phy: phy-cadence-torrent:
 Add platform dependent compatible string

Hi, 

> -----Original Message-----
> From: Rob Herring <robh@...nel.org>
> Sent: Friday, December 20, 2019 2:56
> To: Yuti Suresh Amonkar <yamonkar@...ence.com>
> Cc: linux-kernel@...r.kernel.org; devicetree@...r.kernel.org;
> kishon@...com; mark.rutland@....com; jsarha@...com;
> tomi.valkeinen@...com; praneeth@...com; Milind Parab
> <mparab@...ence.com>; Swapnil Kashinath Jakhade
> <sjakhade@...ence.com>
> Subject: Re: [RESEND PATCH v1 14/15] dt-bindings: phy: phy-cadence-
> torrent: Add platform dependent compatible string
> 
> EXTERNAL MAIL
> 
> 
> On Wed, Dec 11, 2019 at 02:09:19PM +0100, Yuti Amonkar wrote:
> > Add a new compatible string used for TI SoCs using Torrent PHY.
> >
> > Signed-off-by: Yuti Amonkar <yamonkar@...ence.com>
> > ---
> >  Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml | 4
> > +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
> > b/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
> > index 8069498..60e024b 100644
> > --- a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
> > +++ b/Documentation/devicetree/bindings/phy/phy-cadence-
> torrent.yaml
> > @@ -15,7 +15,9 @@ maintainers:
> >
> >  properties:
> >    compatible:
> > -    const: cdns,torrent-phy
> > +    anyOf:
> 
> Should be an enum or if both strings can be present then you need 2 oneOf
> entries for 1 string and 2 strings.
>

We can have only one compatible string at a time, so should I use like this?

compatible:
     enum:
          - cdns,torrent-phy
          - ti,j721e-serdes-10g

> > +      - const: cdns,torrent-phy
> > +      - const: ti,j721e-serdes-10g
> >
> >    clocks:
> >      maxItems: 1
> > --
> > 2.7.4
> >

Thanks & Regards,
Yuti Amonkar