linux-kernel - Re: [PATCH v2] define vmemmap before pfn_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.9999.1912200307400.3767@viisi.sifive.com>
Date:   Fri, 20 Dec 2019 03:08:39 -0800 (PST)
From:   Paul Walmsley <paul.walmsley@...ive.com>
To:     David Abdurachmanov <david.abdurachmanov@...il.com>
cc:     Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        Anup Patel <anup@...infault.org>,
        Mike Rapoport <rppt@...ux.ibm.com>,
        Greentime Hu <greentime.hu@...ive.com>,
        David Abdurachmanov <david.abdurachmanov@...ive.com>,
        Stefan O'Rear <sorear2@...il.com>,
        Yash Shah <yash.shah@...ive.com>,
        Logan Gunthorpe <logang@...tatee.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] define vmemmap before pfn_to_page calls

On Wed, 18 Dec 2019, David Abdurachmanov wrote:

> pfn_to_page & page_to_pfn depend on vmemmap being available before the calls
> if kernel is configured with CONFIG_SPARSEMEM_VMEMMAP=y. This was caused
> by NOMMU changes which moved vmemmap definition bellow functions definitions
> calling pfn_to_page & page_to_pfn.
> 
> Noticed while compiled 5.5-rc2 kernel for Fedora/RISCV.
> 
> v2:
> - Add a comment for vmemmap in source
> 
> Signed-off-by: David Abdurachmanov <david.abdurachmanov@...ive.com>
> Fixes: 6bd33e1ece52 ("riscv: add nommu support")
> Reviewed-by: Anup Patel <anup@...infault.org>

This looks like it was due to my error when resolving the merge conflicts, 
not Christoph's.  Queued for v5.5-rc, thanks David.


- Paul