linux-kernel - Re: [PATCH 1/9] perf/core: Add PERF_RECORD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 20 Dec 2019 20:50:12 +0900
From:   Namhyung Kim <namhyung@...nel.org>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Ingo Molnar <mingo@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Mark Rutland <mark.rutland@....com>,
        Stephane Eranian <eranian@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-perf-users <linux-perf-users@...r.kernel.org>,
        Tejun Heo <tj@...nel.org>, Li Zefan <lizefan@...wei.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Adrian Hunter <adrian.hunter@...el.com>
Subject: Re: [PATCH 1/9] perf/core: Add PERF_RECORD_CGROUP event

On Fri, Dec 20, 2019 at 6:33 PM Peter Zijlstra <peterz@...radead.org> wrote:
> > diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
> > index 377d794d3105..7bae2d3380a6 100644
> > --- a/include/uapi/linux/perf_event.h
> > +++ b/include/uapi/linux/perf_event.h
> > @@ -377,7 +377,8 @@ struct perf_event_attr {
> >                               ksymbol        :  1, /* include ksymbol events */
> >                               bpf_event      :  1, /* include bpf events */
> >                               aux_output     :  1, /* generate AUX records instead of events */
> > -                             __reserved_1   : 32;
> > +                             cgroup         :  1, /* include cgroup events */
> > +                             __reserved_1   : 31;
> >
> >       union {
> >               __u32           wakeup_events;    /* wakeup every n events */
> > @@ -1006,6 +1007,17 @@ enum perf_event_type {
> >        */
> >       PERF_RECORD_BPF_EVENT                   = 18,
> >
> > +     /*
> > +      * struct {
> > +      *      struct perf_event_header        header;
> > +      *      u64                             id;
> > +      *      u64                             path_len;
>
> You can leave out path_len (also u64 for a length field is silly).

Right, will remove.

Thanks
Namhyung


>
> > +      *      char                            path[];
> > +      *      struct sample_id                sample_id;
> > +      * };
> > +      */
> > +     PERF_RECORD_CGROUP                      = 19,