[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <f2f1e320-6a9e-a669-c7c0-0402570b1e9a@puri.sm>
Date: Mon, 23 Dec 2019 09:13:58 +0100
From: Martin Kepplinger <martin.kepplinger@...i.sm>
To: Shawn Guo <shawnguo@...nel.org>,
Martin Kepplinger <martin.kepplinger@...i.sm>
Cc: robh@...nel.org, mark.rutland@....com, kernel@...gutronix.de,
linux-imx@....com, kernel@...i.sm, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: imx8mq-librem5-devkit: add accelerometer and
gyro sensor
On 23.12.19 08:18, Shawn Guo wrote:
> On Mon, Dec 16, 2019 at 10:32:15AM +0100, Martin Kepplinger wrote:
>> On 03.12.19 14:03, Martin Kepplinger wrote:
>>> Now that there is driver support, describe the accel and gyro sensor parts
>>> of the LSM9DS1 IMU.
>>>
>>> Signed-off-by: Martin Kepplinger <martin.kepplinger@...i.sm>
>>> ---
>>> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 7 +++++++
>>> 1 file changed, 7 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
>>> index 683a11035643..7a92704c53ec 100644
>>> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
>>> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
>>> @@ -415,6 +415,13 @@
>>> pinctrl-0 = <&pinctrl_i2c3>;
>>> status = "okay";
>>>
>>> + accel_gyro@6a {
>
> We prefer to use hyphen than underscore in node name. Also nodes with
> unit-address should be sorted in the address.
>
> Shawn
thanks a lot for taking a look. resent.
martin
Powered by blists - more mailing lists