linux-kernel - Re: [PATCH] arm64: dts: imx8mq-librem5-devkit: add accelerometer and gyro sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191223071805.GR11523@dragon>
Date:   Mon, 23 Dec 2019 15:18:06 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Martin Kepplinger <martin.kepplinger@...i.sm>
Cc:     robh@...nel.org, mark.rutland@....com, kernel@...gutronix.de,
        linux-imx@....com, kernel@...i.sm, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: imx8mq-librem5-devkit: add accelerometer and
 gyro sensor

On Mon, Dec 16, 2019 at 10:32:15AM +0100, Martin Kepplinger wrote:
> On 03.12.19 14:03, Martin Kepplinger wrote:
> > Now that there is driver support, describe the accel and gyro sensor parts
> > of the LSM9DS1 IMU.
> > 
> > Signed-off-by: Martin Kepplinger <martin.kepplinger@...i.sm>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> > index 683a11035643..7a92704c53ec 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> > @@ -415,6 +415,13 @@
> >  	pinctrl-0 = <&pinctrl_i2c3>;
> >  	status = "okay";
> >  
> > +	accel_gyro@6a {

We prefer to use hyphen than underscore in node name.  Also nodes with
unit-address should be sorted in the address.

Shawn

> > +		compatible = "st,lsm9ds1-imu";
> > +		reg = <0x6a>;
> > +		vdd-supply = <&reg_3v3_p>;
> > +		vddio-supply = <&reg_3v3_p>;
> > +	};
> > +
> >  	magnetometer@1e	{
> >  		compatible = "st,lsm9ds1-magn";
> >  		reg = <0x1e>;
> > 
> 
> (adding / fixing people in CC)
> 
> Are there any questions about this addition or the followup fix?
> 
> thanks a lot,
> 
>                                martin