linux-kernel - Re: [PATCH] usb: cdns3: gadget: Remove unneeded variable ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 23 Dec 2019 10:53:54 +0200
From:   Roger Quadros <rogerq@...com>
To:     Xu Wang <vulab@...as.ac.cn>, <gregkh@...uxfoundation.org>
CC:     <pawell@...ence.com>, <balbi@...nel.org>, <peter.chen@....com>,
        <colin.king@...onical.com>, <linux-usb@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: cdns3: gadget: Remove unneeded variable ret



On 20/12/2019 09:19, Xu Wang wrote:
> Remove unneeded variable ret used to store return value,just return 0.
> 
> Signed-off-by: Xu Wang <vulab@...as.ac.cn>

Acked-by: Roger Quadros <rogerq@...com>

> ---
>   drivers/usb/cdns3/gadget.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c
> index 4c1e755..73b75a3 100644
> --- a/drivers/usb/cdns3/gadget.c
> +++ b/drivers/usb/cdns3/gadget.c
> @@ -2389,7 +2389,6 @@ static int cdns3_gadget_udc_stop(struct usb_gadget *gadget)
>   	struct cdns3_endpoint *priv_ep;
>   	u32 bEndpointAddress;
>   	struct usb_ep *ep;
> -	int ret = 0;
>   	int val;
>   
>   	priv_dev->gadget_driver = NULL;
> @@ -2413,7 +2412,7 @@ static int cdns3_gadget_udc_stop(struct usb_gadget *gadget)
>   	writel(0, &priv_dev->regs->usb_ien);
>   	writel(USB_CONF_DEVDS, &priv_dev->regs->usb_conf);
>   
> -	return ret;
> +	return 0;
>   }
>   
>   static const struct usb_gadget_ops cdns3_gadget_ops = {
> 

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki