linux-kernel - Re: [PATCH] clocksource/drivers: Fix something in ttc_setup_clockevent and ttc_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 23 Dec 2019 13:43:34 +0100
From:   Markus Elfring <Markus.Elfring@....de>
To:     Navid Emamdoost <navid.emamdoost@...il.com>,
        linux-arm-kernel@...ts.infradead.org
Cc:     Navid Emamdoost <emamd001@....edu>, Kangjie Lu <kjlu@....edu>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Johan Hovold <johan@...nel.org>,
        Michal Simek <michal.simek@...inx.com>,
        Sören Brinkmann <soren.brinkmann@...inx.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clocksource/drivers: Fix something in
 ttc_setup_clockevent and ttc_setup_clocksource

> In the implementation of ttc_setup_clockevent() and
> ttc_setup_clocksource(), the allocated memory for ttccs is leaked when
> clk_notifier_register() fails.

I suggest to correct your commit message.

> Use goto to direct the execution into error handling path.

* Should the desired completion of the exception handling be described
  by an other wording?

* Will it be better to improve the affected functions by
  separate update steps?

* How do you think about to add the tag “Reported-by” for Michal Simek?
  https://lore.kernel.org/linux-arm-kernel/2a6cdb63-397b-280a-7379-740e8f43ddf6@xilinx.com/

…
> +++ b/drivers/clocksource/timer-cadence-ttc.c
…
> @@ -363,16 +363,20 @@  static int __init ttc_setup_clocksource(struct clk *clk, void __iomem *base,
…
>  	return 0;
> +
> +release_ttcce:
> +
> +	kfree(ttcce);
> +	return err;
…

* Please omit a blank line after the label.

* Is there a need to call the function “clk_disable_unprepare”
  by another jump target?

Regards,
Markus