linux-kernel - Re: [PATCH] Revert "iwlwifi: mvm: fix scan config command size"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <946da821-9e54-4508-e3ab-f2cdc19c8084@mageia.org>
Date:   Mon, 23 Dec 2019 14:24:33 +0200
From:   Thomas Backlund <tmb@...eia.org>
To:     Roman Gilg <subdiff@...il.com>,
        Mehmet Akif Tasova <makiftasova@...il.com>
CC:     Johannes Berg <johannes.berg@...el.com>,
        Emmanuel Grumbach <emmanuel.grumbach@...el.com>,
        Luca Coelho <luciano.coelho@...el.com>,
        Intel Linux Wireless <linuxwifi@...el.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        "David S. Miller" <davem@...emloft.net>,
        Shahar S Matityahu <shahar.s.matityahu@...el.com>,
        Tova Mussai <tova.mussai@...el.com>,
        Ayala Beker <ayala.beker@...el.com>,
        Sara Sharon <sara.sharon@...el.com>,
        <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Revert "iwlwifi: mvm: fix scan config command size"

Den 18-12-2019 kl. 21:12, skrev Roman Gilg:
> On Fri, Dec 13, 2019 at 9:36 PM Mehmet Akif Tasova
> <makiftasova@...il.com> wrote:
>>
>> Since Linux 5.4.1 released, iwlwifi could not initialize Intel(R) Dual Band
>> Wireless AC 9462 firmware, failing with following error in dmesg:
>>
>> iwlwifi 0000:00:14.3: FW error in SYNC CMD SCAN_CFG_CMD
>>
>> whole dmesg output of error can be found at:
>> https://gist.github.com/makiftasova/354e46439338f4ab3fba0b77ad5c19ec
>>
>> also bug report from ArchLinux bug tracker (contains more info):
>> https://bugs.archlinux.org/task/64703
> 
> Since this bug report is about the Dell XPS 13 2-in1: I tested your
> revert with this device, but the issue persists at least on this
> device. So these might be two different issues, one for your device
> and another one for the XPS.


Yeah, to get iwlwifi to work somewhat nicely you need this revert, and 
also theese on top of 5.4.6:

 From db5cce1afc8d2475d2c1c37c2a8267dd0e151526 Mon Sep 17 00:00:00 2001
From: Anders Kaseorg <andersk@....edu>
Date: Mon, 2 Dec 2019 17:09:20 -0500
Subject: Revert "iwlwifi: assign directly to iwl_trans->cfg in QuZ 
detection"

 From 0df36b90c47d93295b7e393da2d961b2f3b6cde4 Mon Sep 17 00:00:00 2001
From: Luca Coelho <luciano.coelho@...el.com>
Date: Thu, 5 Dec 2019 09:03:54 +0200
Subject: iwlwifi: pcie: move power gating workaround earlier in the flow

and atleast v2 of the "iwlwifi: mvm: don't send the 
IWL_MVM_RXQ_NSSN_SYNC notif to Rx queues" patch that is being debated on 
this list.

With theese in place, we seem to have it behaving properly again for 
Mageia users reporting various problems / firmware crashes / ...

Hopefully Intel guys will get this sorted soon-ish and all sent to stable@

> 
>> Reverting commit 06eb547c4ae4 ("iwlwifi: mvm: fix scan config command
>> size") seems to fix this issue  until proper solution is found.
>>
>> This reverts commit 06eb547c4ae4382e70d556ba213d13c95ca1801b.
>>
>> Signed-off-by: Mehmet Akif Tasova <makiftasova@...il.com>
>> ---
>>   drivers/net/wireless/intel/iwlwifi/mvm/scan.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
>> index a046ac9fa852..a5af8f4128b1 100644
>> --- a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
>> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
>> @@ -1213,7 +1213,7 @@ static int iwl_mvm_legacy_config_scan(struct iwl_mvm *mvm)
>>                  cmd_size = sizeof(struct iwl_scan_config_v2);
>>          else
>>                  cmd_size = sizeof(struct iwl_scan_config_v1);
>> -       cmd_size += num_channels;
>> +       cmd_size += mvm->fw->ucode_capa.n_scan_channels;
>>
>>          cfg = kzalloc(cmd_size, GFP_KERNEL);
>>          if (!cfg)
>> --
>> 2.24.1
>>
> 

--
Thomas