linux-kernel - Re: [PATCH] Revert "iwlwifi: mvm: fix scan config command size"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <88b9ffdc51ae5e11341332d7f5efed07320251c6.camel@intel.com>
Date:   Mon, 23 Dec 2019 15:52:43 +0200
From:   Luciano Coelho <luciano.coelho@...el.com>
To:     Thomas Backlund <tmb@...eia.org>, Roman Gilg <subdiff@...il.com>,
        Mehmet Akif Tasova <makiftasova@...il.com>
Cc:     Johannes Berg <johannes.berg@...el.com>,
        Emmanuel Grumbach <emmanuel.grumbach@...el.com>,
        Intel Linux Wireless <linuxwifi@...el.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        "David S. Miller" <davem@...emloft.net>,
        Shahar S Matityahu <shahar.s.matityahu@...el.com>,
        Tova Mussai <tova.mussai@...el.com>,
        Ayala Beker <ayala.beker@...el.com>,
        Sara Sharon <sara.sharon@...el.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Revert "iwlwifi: mvm: fix scan config command size"

On Mon, 2019-12-23 at 14:24 +0200, Thomas Backlund wrote:
> Den 18-12-2019 kl. 21:12, skrev Roman Gilg:
> > On Fri, Dec 13, 2019 at 9:36 PM Mehmet Akif Tasova
> > <makiftasova@...il.com> wrote:
> > > Since Linux 5.4.1 released, iwlwifi could not initialize Intel(R) Dual Band
> > > Wireless AC 9462 firmware, failing with following error in dmesg:
> > > 
> > > iwlwifi 0000:00:14.3: FW error in SYNC CMD SCAN_CFG_CMD
> > > 
> > > whole dmesg output of error can be found at:
> > > https://gist.github.com/makiftasova/354e46439338f4ab3fba0b77ad5c19ec
> > > 
> > > also bug report from ArchLinux bug tracker (contains more info):
> > > https://bugs.archlinux.org/task/64703
> > 
> > Since this bug report is about the Dell XPS 13 2-in1: I tested your
> > revert with this device, but the issue persists at least on this
> > device. So these might be two different issues, one for your device
> > and another one for the XPS.
> 
> Yeah, to get iwlwifi to work somewhat nicely you need this revert

Indeed the revert is correct.  I'm going to apply it in our internal
tree and send it out for v5.5-rc* (with stable in CC so it goes to
v5.4).  Thanks Mehmet!


> [...]and also theese on top of 5.4.6:
> 
>  From db5cce1afc8d2475d2c1c37c2a8267dd0e151526 Mon Sep 17 00:00:00 2001
> From: Anders Kaseorg <andersk@....edu>
> Date: Mon, 2 Dec 2019 17:09:20 -0500
> Subject: Revert "iwlwifi: assign directly to iwl_trans->cfg in QuZ 
> detection"
> 
>  From 0df36b90c47d93295b7e393da2d961b2f3b6cde4 Mon Sep 17 00:00:00 2001
> From: Luca Coelho <luciano.coelho@...el.com>
> Date: Thu, 5 Dec 2019 09:03:54 +0200
> Subject: iwlwifi: pcie: move power gating workaround earlier in the flow

The fixes for these two are already in v5.5-rc3, [1] and [2]
respectively.  They are both marked for v5.4, hopefully they'll be
included in v5.4.7.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=db5cce1afc8d2475d2c1c37c2a8267dd0e151526
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0df36b90c47d93295b7e393da2d961b2f3b6cde4


> and atleast v2 of the "iwlwifi: mvm: don't send the 
> IWL_MVM_RXQ_NSSN_SYNC notif to Rx queues" patch that is being debated on 
> this list.

Kalle is on vacation, but when he gets, back we'll decide what to do
with this.  If he really doesn't like our v4, I'll send out a new
version that satisfies him so we can finally fix this bug.


> With theese in place, we seem to have it behaving properly again for 
> Mageia users reporting various problems / firmware crashes / ...

Thanks, Thomas, for the comprehensive list of fixes needed here!


--
Cheers,
Luca.