linux-kernel - Re: [PATCH] misc: Use kzalloc() instead of kmalloc() with flag GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87v9q6afcj.wl-ashutosh.dixit@intel.com>
Date:   Mon, 23 Dec 2019 13:42:36 -0800
From:   "Dixit, Ashutosh" <ashutosh.dixit@...el.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Yi Wang <wang.yi59@....com.cn>, <sudeep.dutt@...el.com>,
        <arnd@...db.de>, <vincent.whitchurch@...s.com>,
        <alexios.zavras@...el.com>, <tglx@...utronix.de>,
        <allison@...utok.net>, <linux-kernel@...r.kernel.org>,
        <xue.zhihong@....com.cn>, <up2wing@...il.com>,
        <wang.liang82@....com.cn>, Huang Zijiang <huang.zijiang@....com.cn>
Subject: Re: [PATCH] misc: Use kzalloc() instead of kmalloc() with flag GFP_ZERO.

On Mon, 23 Dec 2019 04:04:28 -0800, Greg KH wrote:
>
> On Mon, Dec 23, 2019 at 09:51:58AM +0800, Yi Wang wrote:
> > From: Huang Zijiang <huang.zijiang@....com.cn>
> >
> > Use kzalloc instead of manually setting kmalloc
> > with flag GFP_ZERO since kzalloc sets allocated memory
> > to zero.
> >
> > Signed-off-by: Huang Zijiang <huang.zijiang@....com.cn>
> > Signed-off-by: Yi Wang <wang.yi59@....com.cn>
> > ---
> >  drivers/misc/mic/host/mic_boot.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/misc/mic/host/mic_boot.c b/drivers/misc/mic/host/mic_boot.c
> > index 7335759..c1f87a4 100644
> > --- a/drivers/misc/mic/host/mic_boot.c
> > +++ b/drivers/misc/mic/host/mic_boot.c
> > @@ -137,7 +137,7 @@ static void *__mic_dma_alloc(struct device *dev, size_t size,
> >      struct scif_hw_dev *scdev = dev_get_drvdata(dev);
> >      struct mic_device *mdev = scdev_to_mdev(scdev);
> >      dma_addr_t tmp;
> > -    void *va = kmalloc(size, gfp | __GFP_ZERO);
> > +void *va = kzalloc(size, gfp);
>
> Odd indation :(
>
> Always use checkpatch.pl on your patches to ensure you do not add new
> problems.
>
> How did this get past 2 different people???

Sorry, didn't see the mail, it ended up in Junk. Thanks for catching it.