linux-kernel - Re: [PATCH net-next v8 13/14] ethtool: add LINKMODES

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d8a046e9-d832-01a9-7ee0-ae0c84ff20c9@gmail.com>
Date:   Mon, 23 Dec 2019 20:41:48 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Michal Kubecek <mkubecek@...e.cz>,
        David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Cc:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Jiri Pirko <jiri@...nulli.us>, Andrew Lunn <andrew@...n.ch>,
        John Linville <linville@...driver.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Johannes Berg <johannes@...solutions.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v8 13/14] ethtool: add LINKMODES_NTF notification



On 12/22/2019 3:46 PM, Michal Kubecek wrote:
> Send ETHTOOL_MSG_LINKMODES_NTF notification message whenever device link
> settings or advertised modes are modified using ETHTOOL_MSG_LINKMODES_SET
> netlink message or ETHTOOL_SLINKSETTINGS or ETHTOOL_SSET ioctl commands.
> 
> The notification message has the same format as reply to LINKMODES_GET
> request. ETHTOOL_MSG_LINKMODES_SET netlink request only triggers the
> notification if there is a change but the ioctl command handlers do not
> check if there is an actual change and trigger the notification whenever
> the commands are executed.
> 
> As all work is done by ethnl_default_notify() handler and callback
> functions introduced to handle LINKMODES_GET requests, all that remains is
> adding entries for ETHTOOL_MSG_LINKMODES_NTF into ethnl_notify_handlers and
> ethnl_default_notify_ops lookup tables and calls to ethtool_notify() where
> needed.
> 
> Signed-off-by: Michal Kubecek <mkubecek@...e.cz>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian