linux-kernel - Re: [PATCH net-next v8 14/14] ethtool: provide link state with LINKSTATE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <918da8cd-7ebc-b895-85c8-afad9eed6036@gmail.com>
Date:   Mon, 23 Dec 2019 20:44:19 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Michal Kubecek <mkubecek@...e.cz>,
        David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Cc:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Jiri Pirko <jiri@...nulli.us>, Andrew Lunn <andrew@...n.ch>,
        John Linville <linville@...driver.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Johannes Berg <johannes@...solutions.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v8 14/14] ethtool: provide link state with
 LINKSTATE_GET request



On 12/22/2019 3:46 PM, Michal Kubecek wrote:
> Implement LINKSTATE_GET netlink request to get link state information.
> 
> At the moment, only link up flag as provided by ETHTOOL_GLINK ioctl command
> is returned.
> 
> LINKSTATE_GET request can be used with NLM_F_DUMP (without device
> identification) to request the information for all devices in current
> network namespace providing the data.
> 
> Signed-off-by: Michal Kubecek <mkubecek@...e.cz>
> ---

[snip]

> +Kernel response contents:
> +
> +  ====================================  ======  ==========================
> +  ``ETHTOOL_A_LINKSTATE_HEADER``        nested  reply header
> +  ``ETHTOOL_A_LINKSTATE_LINK``          u8      autonegotiation status

^ ==== Humm, auto-negotiation status may not be exactly accurate
especially with complex devices with SerDes/PHY/SFPs/what have you/.
Other than that, the code looks correct:

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian