linux-kernel - [PATCH] firewire: net: remove set but not used variable 'guid'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20191226121815.11495-1-yukuai3@huawei.com>
Date:   Thu, 26 Dec 2019 20:18:15 +0800
From:   yu kuai <yukuai3@...wei.com>
To:     <stefanr@...6.in-berlin.de>
CC:     <linux1394-devel@...ts.sourceforge.net>,
        <linux-kernel@...r.kernel.org>, <yukuai3@...wei.com>,
        <yi.zhang@...wei.com>, <zhengbin13@...wei.com>
Subject: [PATCH] firewire: net: remove set but not used variable 'guid'

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/firewire/net.c: In function ‘fwnet_finish_incoming_packet’:
drivers/firewire/net.c:493:9: warning: variable ‘guid’ set but not
used

It is never used, and so can be removed.

Signed-off-by: yu kuai <yukuai3@...wei.com>
---
 drivers/firewire/net.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c
index 715e491dfbc3..28785642a5c5 100644
--- a/drivers/firewire/net.c
+++ b/drivers/firewire/net.c
@@ -490,7 +490,6 @@ static int fwnet_finish_incoming_packet(struct net_device *net,
 {
 	struct fwnet_device *dev;
 	int status;
-	__be64 guid;
 
 	switch (ether_type) {
 	case ETH_P_ARP:
@@ -512,7 +511,6 @@ static int fwnet_finish_incoming_packet(struct net_device *net,
 	 * Parse the encapsulation header. This actually does the job of
 	 * converting to an ethernet-like pseudo frame header.
 	 */
-	guid = cpu_to_be64(dev->card->guid);
 	if (dev_hard_header(skb, net, ether_type,
 			   is_broadcast ? net->broadcast : net->dev_addr,
 			   NULL, skb->len) >= 0) {
-- 
2.17.2