[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20191227225726.GA1643@archbook>
Date: Fri, 27 Dec 2019 14:57:26 -0800
From: Moritz Fischer <mdf@...nel.org>
To: yu kuai <yukuai3@...wei.com>
Cc: hao.wu@...el.com, mdf@...nel.org, linux-fpga@...r.kernel.org,
linux-kernel@...r.kernel.org, yi.zhang@...we.com,
zhengbin13@...wei.com
Subject: Re: [PATCH] fpga: dfl: fme: remove set but not used variable 'fme'
On Thu, Dec 26, 2019 at 08:16:38PM +0800, yu kuai wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/fpga/dfl-fme-main.c: In function ‘fme_dev_destroy’:
> drivers/fpga/dfl-fme-main.c:678:18: warning: variable ‘fme’ set but not
> used [-Wunused-but-set-variable]
>
> It is never used and so can be removed.
>
> Signed-off-by: yu kuai <yukuai3@...wei.com>
> ---
> drivers/fpga/dfl-fme-main.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/fpga/dfl-fme-main.c b/drivers/fpga/dfl-fme-main.c
> index 7c930e6b314d..1d4690c99268 100644
> --- a/drivers/fpga/dfl-fme-main.c
> +++ b/drivers/fpga/dfl-fme-main.c
> @@ -675,10 +675,8 @@ static int fme_dev_init(struct platform_device *pdev)
> static void fme_dev_destroy(struct platform_device *pdev)
> {
> struct dfl_feature_platform_data *pdata = dev_get_platdata(&pdev->dev);
> - struct dfl_fme *fme;
>
> mutex_lock(&pdata->lock);
> - fme = dfl_fpga_pdata_get_private(pdata);
> dfl_fpga_pdata_set_private(pdata, NULL);
> mutex_unlock(&pdata->lock);
> }
> --
> 2.17.2
>
Acked-by: Moritz Fischer <mdf@...nel.org>
Thanks,
Moritz
Powered by blists - more mailing lists