linux-kernel - Re: [PATCH] fpga: dfl: fme: remove set but not used variable 'fme'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 30 Dec 2019 09:51:40 +0800
From:   Wu Hao <hao.wu@...el.com>
To:     Moritz Fischer <mdf@...nel.org>
Cc:     yu kuai <yukuai3@...wei.com>, linux-fpga@...r.kernel.org,
        linux-kernel@...r.kernel.org, yi.zhang@...we.com,
        zhengbin13@...wei.com
Subject: Re: [PATCH] fpga: dfl: fme: remove set but not used variable 'fme'

On Fri, Dec 27, 2019 at 02:57:26PM -0800, Moritz Fischer wrote:
> On Thu, Dec 26, 2019 at 08:16:38PM +0800, yu kuai wrote:
> > Fixes gcc '-Wunused-but-set-variable' warning:
> > 
> > drivers/fpga/dfl-fme-main.c: In function ‘fme_dev_destroy’:
> > drivers/fpga/dfl-fme-main.c:678:18: warning: variable ‘fme’ set but not
> > used [-Wunused-but-set-variable]
> > 
> > It is never used and so can be removed.
> > 
> > Signed-off-by: yu kuai <yukuai3@...wei.com>
> > ---
> >  drivers/fpga/dfl-fme-main.c | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/drivers/fpga/dfl-fme-main.c b/drivers/fpga/dfl-fme-main.c
> > index 7c930e6b314d..1d4690c99268 100644
> > --- a/drivers/fpga/dfl-fme-main.c
> > +++ b/drivers/fpga/dfl-fme-main.c
> > @@ -675,10 +675,8 @@ static int fme_dev_init(struct platform_device *pdev)
> >  static void fme_dev_destroy(struct platform_device *pdev)
> >  {
> >  	struct dfl_feature_platform_data *pdata = dev_get_platdata(&pdev->dev);
> > -	struct dfl_fme *fme;
> >  
> >  	mutex_lock(&pdata->lock);
> > -	fme = dfl_fpga_pdata_get_private(pdata);
> >  	dfl_fpga_pdata_set_private(pdata, NULL);
> >  	mutex_unlock(&pdata->lock);
> >  }
> > -- 
> > 2.17.2
> > 
> Acked-by: Moritz Fischer <mdf@...nel.org>

Acked-by: Wu Hao <hao.wu@...el.com>

Thanks
Hao

> 
> Thanks,
> Moritz