linux-kernel - Re: [PATCH v8 02/13] exfat: add super block operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKYAXd9pzpQaHcuAR0N-07csf3rQskGcZU35S2Sj8y70XqgN+Q@mail.gmail.com>
Date:   Tue, 31 Dec 2019 22:32:35 +0900
From:   Namjae Jeon <linkinjeon@...il.com>
To:     Pali Rohár <pali.rohar@...il.com>
Cc:     Namjae Jeon <namjae.jeon@...sung.com>,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        gregkh@...uxfoundation.org, valdis.kletnieks@...edu, hch@....de,
        sj1557.seo@...sung.com
Subject: Re: [PATCH v8 02/13] exfat: add super block operations

>> +	if (le16_to_cpu(p_bpb->bsx.vol_flags) & VOL_DIRTY) {
>> +		sbi->vol_flag |= VOL_DIRTY;
>> +		exfat_msg(sb, KERN_WARNING,
>> +			"Volume was not properly unmounted. Some data may be corrupt. Please
>> run fsck.");
>
> Hello, do you have some pointers which fsck tool should user run in this
> case?
Hello,
Only windows recovery tool for now. fsck in fuse-exfat is early stage yet.
So I am preparing exfat-tools included a reliable fsck.

>
>> +	}
>> +
>> +	ret = exfat_create_upcase_table(sb);
>> +	if (ret) {
>> +		exfat_msg(sb, KERN_ERR, "failed to load upcase table");
>> +		goto free_bh;
>> +	}
>> +
>> +	/* allocate-bitmap is only for exFAT */
>
> It looks like that this comment is relict from previous version which
> had also FAT32 code included...
Yes, It is leftover from vfat support in sdfat, Will remove it.

Thanks!