linux-kernel - Re: [PATCH v8 09/13] exfat: add misc operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKYAXd_KLP_179DA9GbAdHyF=A9G9dnWm5hR4pGqds9OSgJhcw@mail.gmail.com>
Date:   Tue, 31 Dec 2019 22:34:04 +0900
From:   Namjae Jeon <linkinjeon@...il.com>
To:     Pali Rohár <pali.rohar@...il.com>
Cc:     Namjae Jeon <namjae.jeon@...sung.com>,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        gregkh@...uxfoundation.org, valdis.kletnieks@...edu, hch@....de,
        sj1557.seo@...sung.com
Subject: Re: [PATCH v8 09/13] exfat: add misc operations

>> +#if (BITS_PER_LONG == 64)
>> +	if (second >= UNIX_SECS_2108) {
>> +		tp->second  = 59;
>> +		tp->minute  = 59;
>> +		tp->hour = 23;
>> +		tp->day  = 31;
>> +		tp->month  = 12;
>> +		tp->year = 127;
>> +		return;
>> +	}
>> +#endif
>
> Hello! Why is this code #if-ed? Kernel supports 64 bit long long
> integers also for 32 bit platforms.
>
> Function parameter struct timespec64 *ts is already 64 bit. so above
> #if-code looks really suspicious.
Right, Will remove it.

Thanks for your review!