linux-kernel - Re: [PATCH v8 01/13] exfat: add in-memory and on-disk structures and headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKYAXd8WwMXSAicX=bx5vu=1GdXW0h4Lg_atxtdC7NLLo8E=SA@mail.gmail.com>
Date:   Tue, 31 Dec 2019 22:46:51 +0900
From:   Namjae Jeon <linkinjeon@...il.com>
To:     Pali Rohár <pali.rohar@...il.com>
Cc:     Namjae Jeon <namjae.jeon@...sung.com>,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        gregkh@...uxfoundation.org, valdis.kletnieks@...edu, hch@....de,
        sj1557.seo@...sung.com
Subject: Re: [PATCH v8 01/13] exfat: add in-memory and on-disk structures and headers

>> +
>> +#define ATTR_READONLY_LE	cpu_to_le16(0x0001)
>> +#define ATTR_HIDDEN_LE		cpu_to_le16(0x0002)
>> +#define ATTR_SYSTEM_LE		cpu_to_le16(0x0004)
>> +#define ATTR_VOLUME_LE		cpu_to_le16(0x0008)
>> +#define ATTR_SUBDIR_LE		cpu_to_le16(0x0010)
>> +#define ATTR_ARCHIVE_LE		cpu_to_le16(0x0020)
>
> Hello!
>
> This looks like copy-paste code from /* file attributes */ section
> above. What about at least making these macro definitions as?
Yes, will remove unused file attribute macros.
>
>   #define ATTR_READONLY_LE	cpu_to_le16(ATTR_READONLY)
>   #define ATTR_HIDDEN_LE	cpu_to_le16(ATTR_HIDDEN)
>   ...
>
> But main question is, are these _LE definitions needed at all?

>
> Looking at the whole patch series and only ATTR_SUBDIR_LE and
> ATTR_ARCHIVE_LE are used.
>
> Is not it better to use cpu_to_le16(ATTR_READONLY) directly in code and
> do not define duplicate ATTR_READONLY_LE macro at all?
I can change them as you pointed out.

Thanks!
>