[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <MN2PR21MB1375DB84228137F30E9C1891CA260@MN2PR21MB1375.namprd21.prod.outlook.com>
Date: Tue, 31 Dec 2019 15:50:32 +0000
From: Haiyang Zhang <haiyangz@...rosoft.com>
To: Michael Kelley <mikelley@...rosoft.com>,
"sashal@...nel.org" <sashal@...nel.org>,
"linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC: KY Srinivasan <kys@...rosoft.com>,
Stephen Hemminger <sthemmin@...rosoft.com>,
"olaf@...fle.de" <olaf@...fle.de>, vkuznets <vkuznets@...hat.com>,
"davem@...emloft.net" <davem@...emloft.net>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH V2,net-next, 2/3] Drivers: hv: vmbus: Add dev_num to sysfs
> -----Original Message-----
> From: Michael Kelley <mikelley@...rosoft.com>
> Sent: Monday, December 30, 2019 8:35 PM
> To: Haiyang Zhang <haiyangz@...rosoft.com>; sashal@...nel.org; linux-
> hyperv@...r.kernel.org; netdev@...r.kernel.org
> Cc: Haiyang Zhang <haiyangz@...rosoft.com>; KY Srinivasan
> <kys@...rosoft.com>; Stephen Hemminger <sthemmin@...rosoft.com>;
> olaf@...fle.de; vkuznets <vkuznets@...hat.com>; davem@...emloft.net;
> linux-kernel@...r.kernel.org
> Subject: RE: [PATCH V2,net-next, 2/3] Drivers: hv: vmbus: Add dev_num to sysfs
>
> From: Haiyang Zhang <haiyangz@...rosoft.com> Sent: Monday, December 30,
> 2019 12:14 PM
> >
> > It's a number based on the vmbus device offer sequence.
>
> Let's use "VMBus" as the capitalization.
I will.
>
> > Useful for device naming when using Async probing.
> >
> > Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>
> > ---
> > Documentation/ABI/stable/sysfs-bus-vmbus | 8 ++++++++
> > drivers/hv/vmbus_drv.c | 13 +++++++++++++
> > 2 files changed, 21 insertions(+)
> >
> > diff --git a/Documentation/ABI/stable/sysfs-bus-vmbus
> > b/Documentation/ABI/stable/sysfs-bus-vmbus
> > index 8e8d167..a42225d 100644
> > --- a/Documentation/ABI/stable/sysfs-bus-vmbus
> > +++ b/Documentation/ABI/stable/sysfs-bus-vmbus
> > @@ -49,6 +49,14 @@ Contact: Stephen Hemminger
> <sthemmin@...rosoft.com>
> > Description: This NUMA node to which the VMBUS device is
> > attached, or -1 if the node is unknown.
> >
> > +What: /sys/bus/vmbus/devices/<UUID>/dev_num
> > +Date: Dec 2019
> > +KernelVersion: 5.5
> > +Contact: Haiyang Zhang <haiyangz@...rosoft.com>
> > +Description: A number based on the vmbus device offer sequence.
>
> The capitalization of "VMBus" is already inconsistent in this file in that
> we have "VMBus" and "VMBUS" in the text. Let's not introduce another
> capitalization -- use "VMBus".
I will use "VMBus".
Thanks,
- Haiyang
Powered by blists - more mailing lists