linux-kernel - Re: [PATCH] early init: open /dev/console with O

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOzgRdaaxN+BFnx8p2OabC8E9JgcU2VKM=MeGmn9ecmdhJrfLA@mail.gmail.com>
Date:   Tue, 31 Dec 2019 23:55:35 +0800
From:   youling 257 <youling257@...il.com>
To:     Dominik Brodowski <linux@...inikbrodowski.net>
Cc:     torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
        viro@...iv.linux.org.uk
Subject: Re: [PATCH] early init: open /dev/console with O_LARGEFILE

test this patch, still can see /system/bin/sh warning.
this patch no help for me.

2019-12-31 23:02 GMT+08:00, Dominik Brodowski <linux@...inikbrodowski.net>:
> If force_o_largefile() is true, /dev/console used to be opened
> with O_LARGEFILE. Retain that behaviour.
>
> Fixes: 8243186f0cc7 ("fs: remove ksys_dup()")
> Signed-off-by: Dominik Brodowski <linux@...inikbrodowski.net>
>
> diff --git a/init/main.c b/init/main.c
> index 1ecfd43ed464..d12777775cb0 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -1162,7 +1162,8 @@ void console_on_rootfs(void)
>  	unsigned int i;
>
>  	/* Open /dev/console in kernelspace, this should never fail */
> -	file = filp_open("/dev/console", O_RDWR, 0);
> +	file = filp_open("/dev/console",
> +			  O_RDWR | (force_o_largefile() ? O_LARGEFILE : 0), 0);
>  	if (IS_ERR(file))
>  		goto err_out;
>
>