linux-kernel - Re: [PATCH v9 11/13] exfat: add Kconfig and Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200102125338.pf3aw62qtnch5oqa@pali>
Date:   Thu, 2 Jan 2020 13:53:38 +0100
From:   Pali Rohár <pali.rohar@...il.com>
To:     Namjae Jeon <namjae.jeon@...sung.com>
Cc:     linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        gregkh@...uxfoundation.org, valdis.kletnieks@...edu, hch@....de,
        sj1557.seo@...sung.com, linkinjeon@...il.com
Subject: Re: [PATCH v9 11/13] exfat: add Kconfig and Makefile

On Thursday 02 January 2020 16:20:34 Namjae Jeon wrote:
> This adds the Kconfig and Makefile for exfat.
> 
> Signed-off-by: Namjae Jeon <namjae.jeon@...sung.com>
> Signed-off-by: Sungjong Seo <sj1557.seo@...sung.com>
> ---
>  fs/exfat/Kconfig  | 21 +++++++++++++++++++++
>  fs/exfat/Makefile |  8 ++++++++
>  2 files changed, 29 insertions(+)
>  create mode 100644 fs/exfat/Kconfig
>  create mode 100644 fs/exfat/Makefile
> 
> diff --git a/fs/exfat/Kconfig b/fs/exfat/Kconfig
> new file mode 100644
> index 000000000000..11d841a5f7f0
> --- /dev/null
> +++ b/fs/exfat/Kconfig
> @@ -0,0 +1,21 @@
> +# SPDX-License-Identifier: GPL-2.0-or-later
> +
> +config EXFAT
> +	tristate "exFAT filesystem support"
> +	select NLS
> +	help
> +	  This allows you to mount devices formatted with the exFAT file system.
> +	  exFAT is typically used on SD-Cards or USB sticks.
> +
> +	  To compile this as a module, choose M here: the module will be called
> +	  exfat.
> +
> +config EXFAT_FS_DEFAULT_IOCHARSET
> +	string "Default iocharset for exFAT"
> +	default "utf8"
> +	depends on EXFAT
> +	help

Hello! We have already config option FAT_DEFAULT_IOCHARSET. Cannot it be
reused? FAT_DEFAULT_IOCHARSET is used for msdos.ko and vfat.ko, both are
from FAT drivers family. So it looks like that FAT_DEFAULT_IOCHARSET
could be used also for exFAT which belongs to FAT fs family.

> +	  Set this to the default input/output character set you'd
> +	  like exFAT to use. It should probably match the character set
> +	  that most of your exFAT filesystems use, and can be overridden
> +	  with the "iocharset" mount option for exFAT filesystems.
> diff --git a/fs/exfat/Makefile b/fs/exfat/Makefile
> new file mode 100644
> index 000000000000..e9193346c80c
> --- /dev/null
> +++ b/fs/exfat/Makefile
> @@ -0,0 +1,8 @@
> +# SPDX-License-Identifier: GPL-2.0-or-later
> +#
> +# Makefile for the linux exFAT filesystem support.
> +#
> +obj-$(CONFIG_EXFAT) += exfat.o
> +
> +exfat-y	:= inode.o namei.o dir.o super.o fatent.o cache.o nls.o misc.o \
> +	   file.o balloc.o

-- 
Pali Rohár
pali.rohar@...il.com