linux-kernel - Re: [PATCH] mtd: onenand: omap2: Pass correct flags for prep_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 4 Jan 2020 09:46:23 +0100
From:   "H. Nikolaus Schaller" <hns@...delico.com>
To:     Peter Ujfalusi <peter.ujfalusi@...com>
Cc:     kyungmin.park@...sung.com,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Aaro Koskinen <aaro.koskinen@....fi>,
        Vignesh Raghavendra <vigneshr@...com>,
        Tony Lindgren <tony@...mide.com>,
        linux-mtd@...ts.infradead.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux-OMAP <linux-omap@...r.kernel.org>,
        Discussions about the Letux Kernel 
        <letux-kernel@...nphoenux.org>
Subject: Re: [PATCH] mtd: onenand: omap2: Pass correct flags for prep_dma_memcpy


> Am 04.01.2020 um 08:34 schrieb Peter Ujfalusi <peter.ujfalusi@...com>:
> 
> The commit converting the driver to DMAengine was missing the flags for
> the memcpy prepare call.
> It went unnoticed since the omap-dma drive was ignoring them.

s/drive/driver/

> 
> Fixes: 3ed6a4d1de2c5 (" mtd: onenand: omap2: Convert to use dmaengine for memcp")
> Reported-by: Aaro Koskinen <aaro.koskinen@....fi>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>
> ---
> Hi,
> 
> Aaro reported [1] a failure on omap2-onenand pointing to
> 4689d35c765c696bdf0535486a990038b242a26b. It looks like the root cause is the
> conversion of omap2-onenand to DMAengine which missed the flags.
> 
> Basically the client is waiting for a callback without asking for it. This
> certainly causes timeout.
> 
> I have not tested the patch, but it should fix the issue.

makes the gta04a5one.dts work again.

Tested-by: H. Nikolaus Schaller <hns@...delico.com>

BR and thanks!
Nikolaus

> 
> [1] https://lore.kernel.org/lkml/20200103081726.GD15023@darkstar.musicnaut.iki.fi/
> 
> drivers/mtd/nand/onenand/omap2.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/onenand/omap2.c b/drivers/mtd/nand/onenand/omap2.c
> index edf94ee54ec7..71a632b815aa 100644
> --- a/drivers/mtd/nand/onenand/omap2.c
> +++ b/drivers/mtd/nand/onenand/omap2.c
> @@ -328,7 +328,8 @@ static inline int omap2_onenand_dma_transfer(struct omap2_onenand *c,
> 	struct dma_async_tx_descriptor *tx;
> 	dma_cookie_t cookie;
> 
> -	tx = dmaengine_prep_dma_memcpy(c->dma_chan, dst, src, count, 0);
> +	tx = dmaengine_prep_dma_memcpy(c->dma_chan, dst, src, count,
> +				       DMA_CTRL_ACK | DMA_PREP_INTERRUPT);
> 	if (!tx) {
> 		dev_err(&c->pdev->dev, "Failed to prepare DMA memcpy\n");
> 		return -EIO;
> -- 
> Peter
> 
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>