| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <3a98d701-3400-dc46-167c-214a68ff9c04@codeaurora.org>
Date: Mon, 6 Jan 2020 10:55:01 +0530
From: Sricharan R <sricharan@...eaurora.org>
To: Rob Herring <robh@...nel.org>
Cc: devicetree@...r.kernel.org, sboyd@...nel.org,
linux-arm-msm@...r.kernel.org, linus.walleij@...aro.org,
linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
agross@...nel.org, sivaprak@...eaurora.org,
linux-soc@...r.kernel.org, linux-clk@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH V3 1/5] dt-bindings: pinctrl: qcom: Add ipq6018 pinctrl
bindings
Hi Rob,
Thanks for the review.
On 1/4/2020 6:28 AM, Rob Herring wrote:
> On Fri, Jan 03, 2020 at 05:19:33PM +0530, Sricharan R wrote:
>> Add device tree binding Documentation details for ipq6018
>> pinctrl driver.
>>
>> Co-developed-by: Rajkumar Ayyasamy <arajkuma@...eaurora.org>
>> Signed-off-by: Rajkumar Ayyasamy <arajkuma@...eaurora.org>
>> Co-developed-by: Selvam Sathappan Periakaruppan <speriaka@...eaurora.org>
>> Signed-off-by: Selvam Sathappan Periakaruppan <speriaka@...eaurora.org>
>> Co-developed-by: Sivaprakash Murugesan <sivaprak@...eaurora.org>
>> Signed-off-by: Sivaprakash Murugesan <sivaprak@...eaurora.org>
>> Signed-off-by: Sricharan R <sricharan@...eaurora.org>
>> ---
>> [v3] Fixed the example dt node, inherited properties
>>
>> .../bindings/pinctrl/qcom,ipq6018-pinctrl.yaml | 166 +++++++++++++++++++++
>> 1 file changed, 166 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
>> new file mode 100644
>> index 0000000..e959c5f
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
>> @@ -0,0 +1,166 @@
>> +# SPDX-License-Identifier: GPL-2.0-or-later
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/pinctrl/qcom,ipq6018-pinctrl.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Technologies, Inc. IPQ6018 TLMM block
>> +
>> +maintainers:
>> + - Sricharan R <sricharan@...eaurora.org>
>> +
>> +description: |
>> + This binding describes the Top Level Mode Multiplexer block found in the
>> + IPQ6018 platform.
>> +
>> +properties:
>> + compatible:
>> + const: qcom,ipq6018-pinctrl
>
> A blank line after each property schema is preferred.
ok.
>
>> + reg:
>> + maxItems: 1
>> + interrupts:
>> + Description: Specifies the TLMM summary IRQ
>> + maxItems: 1
>> + interrupt-controller: true
>> + '#interrupt-cells':
>> + Description:
>> + Specifies the PIN numbers and Flags, as defined in defined in
>> + include/dt-bindings/interrupt-controller/irq.h
>> + const: 2
>> + gpio-controller: true
>> + '#gpio-cells':
>> + Description: Specifying the pin number and flags, as defined in
>> + include/dt-bindings/gpio/gpio.h
>> + const: 2
>> + gpio-ranges:
>> + Description: Documentation/devicetree/bindings/gpio/gpio.txt
>> + maxItems: 1
>> +
>> +#PIN CONFIGURATION NODES
>> +patternProperties:
>> + '-pins$':
>> + type: object
>> + Description:
>> + Pinctrl node's client devices use subnodes for desired pin configuration.
>> + Client device subnodes use below standard properties.
>> +
>> + Properties:
>
> Did you run 'make dt_binding_check' and is dt-schema up to date? This
> isn't valid json-schema which is case sensitive.
ok, will run the checks and will fix it.
>
>> + pins:
>> + allOf:
>> + $ref: /schemas/types.yaml#/definitions/string
>
> Also not valid as allOf is a list.
>
ok, will fix
>> + enum:
>> + gpio0-gpio80
>
> As is 'enum'...
ok.
>
>> + sdc1_clk
>> + sdc1_cmd
>> + sdc1_data
>> + sdc2_clk
>> + sdc2_cmd
>> + sdc2_data
>> + qdsd_cmd
>> + qdsd_data0
>> + qdsd_data1
>> + qdsd_data2
>> + qdsd_data3
>> + Description:
>> + List of gpio pins affected by the properties specified in this
>> + subnode.
>> +
>> + function:
>> + allOf:
>> + $ref: /schemas/types.yaml#/definitions/string
>> + enum:
>> + adsp_ext, alsp_int, atest_bbrx0, atest_bbrx1, atest_char,
>> + atest_char0, atest_char1, atest_char2, atest_char3, atest_combodac,
>> + atest_gpsadc0, atest_gpsadc1, atest_tsens, atest_wlan0,
>> + atest_wlan1, backlight_en, bimc_dte0, bimc_dte1, blsp_i2c1,
>> + blsp_i2c2, blsp_i2c3, blsp_i2c4, blsp_i2c5, blsp_i2c6, blsp_spi1,
>> + blsp_spi1_cs1, blsp_spi1_cs2, blsp_spi1_cs3, blsp_spi2,
>> + blsp_spi2_cs1, blsp_spi2_cs2, blsp_spi2_cs3, blsp_spi3,
>> + blsp_spi3_cs1, blsp_spi3_cs2, blsp_spi3_cs3, blsp_spi4, blsp_spi5,
>> + blsp_spi6, blsp_uart1, blsp_uart2, blsp_uim1, blsp_uim2, cam1_rst,
>> + cam1_standby, cam_mclk0, cam_mclk1, cci_async, cci_i2c, cci_timer0,
>> + cci_timer1, cci_timer2, cdc_pdm0, codec_mad, dbg_out, display_5v,
>> + dmic0_clk, dmic0_data, dsi_rst, ebi0_wrcdc, euro_us, ext_lpass,
>> + flash_strobe, gcc_gp1_clk_a, gcc_gp1_clk_b, gcc_gp2_clk_a,
>> + gcc_gp2_clk_b, gcc_gp3_clk_a, gcc_gp3_clk_b, gpio, gsm0_tx0,
>> + gsm0_tx1, gsm1_tx0, gsm1_tx1, gyro_accl, kpsns0, kpsns1, kpsns2,
>> + ldo_en, ldo_update, mag_int, mdp_vsync, modem_tsync, m_voc,
>> + nav_pps, nav_tsync, pa_indicator, pbs0, pbs1, pbs2, pri_mi2s,
>> + pri_mi2s_ws, prng_rosc, pwr_crypto_enabled_a, pwr_crypto_enabled_b,
>> + pwr_modem_enabled_a, pwr_modem_enabled_b, pwr_nav_enabled_a,
>> + pwr_nav_enabled_b, qdss_ctitrig_in_a0, qdss_ctitrig_in_a1,
>> + qdss_ctitrig_in_b0, qdss_ctitrig_in_b1, qdss_ctitrig_out_a0,
>> + qdss_ctitrig_out_a1, qdss_ctitrig_out_b0, qdss_ctitrig_out_b1,
>> + qdss_traceclk_a, qdss_traceclk_b, qdss_tracectl_a, qdss_tracectl_b,
>> + qdss_tracedata_a, qdss_tracedata_b, reset_n, sd_card, sd_write,
>> + sec_mi2s, smb_int, ssbi_wtr0, ssbi_wtr1, uim1, uim2, uim3,
>> + uim_batt, wcss_bt, wcss_fm, wcss_wlan, webcam1_rst
>> + Description:
>> + Specify the alternative function to be configured for the specified
>> + pins.
>> + bias-disable:
>> + allOf:
>> + $ref: /schemas/pinctrl/pincfg-node.yaml
>
> While you should have this reference, it is at the wrong level. The node
> needs to reference this schema, not the properties.
>
ok, will fix here and below properties as well.
Regards,
Sricharan
>> + Description:
>> + The specified pins should be configured as no pull.
>> + bias-pull-down:
>> + allOf:
>> + $ref: /schemas/pinctrl/pincfg-node.yaml
>> + Description:
>> + The specified pins should be configured as pull down.
>> + bias-pull-up:
>> + allOf:
>> + $ref: /schemas/pinctrl/pincfg-node.yaml
>> + Description:
>> + The specified pins should be configured as pull up.
>> + output-high:
>> + allOf:
>> + $ref: /schemas/pinctrl/pincfg-node.yaml
>> + Description:
>> + The specified pins are configured in output mode, driven high.
>> + This option is not available for sdc pins.
>> + output-low:
>> + allOf:
>> + $ref: /schemas/pinctrl/pincfg-node.yaml
>> + Description:
>> + The specified pins are configured in output mode, driven low.
>> + This option is not available for sdc pins.
>> + drive-strength:
>> + allOf:
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + enum: [2, 4, 6, 8, 10, 12, 14, 16]
>> + Description:
>> + Selects the drive strength for the specified pins, in mA.
>> +
>> + required:
>> + - pins
>> + - function
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - interrupts
>> + - interrupt-controller
>> + - '#interrupt-cells'
>> + - gpio-controller
>> + - '#gpio-cells'
>> + - gpio-ranges
>> +
>> +example:
>> + tlmm: pinctrl@...0000 {
>> + compatible = "qcom,ipq6018-pinctrl";
>> + reg = <0x01000000 0x300000>;
>> + interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
>> + gpio-controller;
>> + #gpio-cells = <2>;
>> + gpio-ranges = <&tlmm 0 80>;
>> + interrupt-controller;
>> + #interrupt-cells = <2>;
>> +
>> + serial_3_pins: serial3-pinmux {
>> + pins = "gpio44", "gpio45";
>> + function = "blsp2_uart";
>> + drive-strength = <8>;
>> + bias-pull-down;
>> + };
>> + };
>> --
>> 1.9.1
>>
--
"QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Powered by blists - more mailing lists