linux-kernel - Re: [PATCH v10 6/6] backlight: add led-backlight driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200107134540.x5tngzoslssesb2y@ucw.cz>
Date:   Tue, 7 Jan 2020 14:45:40 +0100
From:   Pavel Machek <pavel@....cz>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Tony Lindgren <tony@...mide.com>,
        Jean-Jacques Hiblot <jjhiblot@...com>,
        jacek.anaszewski@...il.com, sre@...nel.org, robh+dt@...nel.org,
        mark.rutland@....com, daniel.thompson@...aro.org, dmurphy@...com,
        linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, tomi.valkeinen@...com
Subject: Re: [PATCH v10 6/6] backlight: add led-backlight driver

Hi!

> > * Jean-Jacques Hiblot <jjhiblot@...com> [700101 00:00]:
> > > From: Tomi Valkeinen <tomi.valkeinen@...com>
> > > 
> > > This patch adds a led-backlight driver (led_bl), which is similar to
> > > pwm_bl except the driver uses a LED class driver to adjust the
> > > brightness in the HW. Multiple LEDs can be used for a single backlight.
> > ...
> > 
> > > +	ret = of_property_read_u32(node, "default-brightness", &value);
> > > +	if (!ret && value <= priv->max_brightness)
> > > +		priv->default_brightness = value;
> > > +	else if (!ret  && value > priv->max_brightness)
> > > +		dev_warn(dev, "Invalid default brightness. Ignoring it\n");
> > 
> > Hmm so just wondering.. Are we using "default-brightness" instead of the
> > usual "default-brightness-level" here?
> 
> Did this get answered?
> 
> > Please Cc me on the next patchset too :)
> 
> I've been waiting for v11.

I guess I could just remove it from a merge for now if there's no other
fix.

Best regards,
								Pavel