linux-kernel - Re: [PATCH v4 20/20] usb: host: ehci-tegra: Remove unused fields from tegra_ehci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b5c262a9-4a7f-6293-e3c4-31ba4822cd12@gmail.com>
Date:   Tue, 7 Jan 2020 19:13:12 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Alan Stern <stern@...land.harvard.edu>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Peter Chen <Peter.Chen@....com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Felipe Balbi <balbi@...nel.org>,
        Michał Mirosław <mirq-linux@...e.qmqm.pl>,
        linux-usb@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 20/20] usb: host: ehci-tegra: Remove unused fields from
 tegra_ehci_hcd

06.01.2020 18:16, Alan Stern пишет:
> On Mon, 6 Jan 2020, Dmitry Osipenko wrote:
> 
>> There are few stale fields in tegra_ehci_hcd structure, let's remove them.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
>> ---
>>  drivers/usb/host/ehci-tegra.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c
>> index 1eb94205a5ac..d6433f206c17 100644
>> --- a/drivers/usb/host/ehci-tegra.c
>> +++ b/drivers/usb/host/ehci-tegra.c
>> @@ -42,12 +42,10 @@ struct tegra_ehci_soc_config {
>>  };
>>  
>>  struct tegra_ehci_hcd {
>> -	struct tegra_usb_phy *phy;
>>  	struct clk *clk;
>>  	struct reset_control *rst;
>>  	int port_resuming;
>>  	bool needs_double_reset;
>> -	enum tegra_usb_phy_port_speed port_speed;
>>  };
>>  
>>  static int tegra_reset_usb_controller(struct platform_device *pdev)
> 
> For patches 2, 19, and 20:
> 
> Acked-by: Alan Stern <stern@...land.harvard.edu>
> 
> It's nice to see that patch 2 makes the sequence of events in 
> tegra_ehci_remove() exactly the same as the failure pathway in 
> tegra_ehci_probe().

Thank you very much for taking a look at the patches!