linux-kernel - Re: [PATCH] video: fbdev: mmp: fix platform_get_irq.cocci warnings

Open Source and information security mailing list archives

Message-ID: <20200107161401.GF43062@phenom.ffwll.local>
Date:   Tue, 7 Jan 2020 17:14:01 +0100
From:   Daniel Vetter <daniel@...ll.ch>
To:     Julia Lawall <julia.lawall@...ia.fr>
Cc:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        linux-fbdev@...r.kernel.org, kbuild-all@...ts.01.org,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        Steve Winslow <swinslow@...il.com>,
        Jilayne Lovejoy <opensource@...ayne.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Allison Randal <allison@...utok.net>
Subject: Re: [PATCH] video: fbdev: mmp: fix platform_get_irq.cocci warnings

On Sat, Jan 04, 2020 at 09:43:31PM +0100, Julia Lawall wrote:
> From: kbuild test robot <lkp@...el.com>
> 
> Remove dev_err() messages after platform_get_irq*() failures.
> Line 450 is redundant because platform_get_irq() already prints
> an error.
> 
> Generated by: scripts/coccinelle/api/platform_get_irq.cocci
> 
> Fixes: dd90e9ae55a1 ("video: fbdev: mmp: add COMPILE_TEST support")
> Signed-off-by: kbuild test robot <lkp@...el.com>
> Signed-off-by: Julia Lawall <julia.lawall@...ia.fr>

Applied to drm-misc-next, thanks for your patch.
-Daniel

> 
> ---
> 
> tree:   git://anongit.freedesktop.org/drm/drm-misc for-linux-next
> head:   80805774fc354f9ae7755a8e649a01dedfd0dcf8
> commit: dd90e9ae55a1e7efd3ac036afe9f7ae7bb64d39d [2/16] video: fbdev: mmp: add COMPILE_TEST support
> :::::: branch date: 11 hours ago
> :::::: commit date: 11 hours ago
> 
>  mmp_ctrl.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
> +++ b/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
> @@ -447,7 +447,6 @@ static int mmphw_probe(struct platform_d
> 
>  	irq = platform_get_irq(pdev, 0);
>  	if (irq < 0) {
> -		dev_err(&pdev->dev, "%s: no IRQ defined\n", __func__);
>  		ret = -ENOENT;
>  		goto failed;
>  	}
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives