linux-kernel - Re: [PATCH V3 1/4] clk: imx: gate4: Switch imx_clk_gate4_flags() to clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200108083031.kpcmlujhpu5fein2@fsr-ub1664-175>
Date:   Wed, 8 Jan 2020 08:30:34 +0000
From:   Abel Vesa <abel.vesa@....com>
To:     Anson Huang <anson.huang@....com>
CC:     "mturquette@...libre.com" <mturquette@...libre.com>,
        "sboyd@...nel.org" <sboyd@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "will@...nel.org" <will@...nel.org>,
        "bjorn.andersson@...aro.org" <bjorn.andersson@...aro.org>,
        "olof@...om.net" <olof@...om.net>,
        "maxime@...no.tech" <maxime@...no.tech>,
        Leonard Crestez <leonard.crestez@....com>,
        "dinguyen@...nel.org" <dinguyen@...nel.org>,
        "marcin.juszkiewicz@...aro.org" <marcin.juszkiewicz@...aro.org>,
        Jacky Bai <ping.bai@....com>,
        "nsekhar@...com" <nsekhar@...com>,
        "t-kristo@...com" <t-kristo@...com>, Peng Fan <peng.fan@....com>,
        "yuehaibing@...wei.com" <yuehaibing@...wei.com>,
        Aisheng Dong <aisheng.dong@....com>,
        "sfr@...b.auug.org.au" <sfr@...b.auug.org.au>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH V3 1/4] clk: imx: gate4: Switch imx_clk_gate4_flags() to
 clk_hw based API

On 20-01-08 09:53:34, Anson Huang wrote:
> Switch the imx_clk_gate4_flags() function to clk_hw based API, rename
> accordingly and add a macro for clk based legacy. This allows us to
> move closer to a clear split between consumer and provider clk APIs.
> 
> Signed-off-by: Anson Huang <Anson.Huang@....com>

For the entire patchset:

Reviewed-by: Abel Vesa <abel.vesa@....com>

> ---
> Changes since V2:
> 	- Switch to latest i.MX clock driver base to redo the patch.
> ---
>  drivers/clk/imx/clk.h | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/imx/clk.h b/drivers/clk/imx/clk.h
> index 65d80c6..b05213b 100644
> --- a/drivers/clk/imx/clk.h
> +++ b/drivers/clk/imx/clk.h
> @@ -390,15 +390,18 @@ static inline struct clk_hw *imx_clk_hw_gate4(const char *name, const char *pare
>  			reg, shift, 0x3, 0, &imx_ccm_lock, NULL);
>  }
>  
> -static inline struct clk *imx_clk_gate4_flags(const char *name,
> +static inline struct clk_hw *imx_clk_hw_gate4_flags(const char *name,
>  		const char *parent, void __iomem *reg, u8 shift,
>  		unsigned long flags)
>  {
> -	return clk_register_gate2(NULL, name, parent,
> +	return clk_hw_register_gate2(NULL, name, parent,
>  			flags | CLK_SET_RATE_PARENT | CLK_OPS_PARENT_ENABLE,
>  			reg, shift, 0x3, 0, &imx_ccm_lock, NULL);
>  }
>  
> +#define imx_clk_gate4_flags(name, parent, reg, shift, flags) \
> +	to_clk(imx_clk_hw_gate4_flags(name, parent, reg, shift, flags))
> +
>  static inline struct clk_hw *imx_clk_hw_mux(const char *name, void __iomem *reg,
>  			u8 shift, u8 width, const char * const *parents,
>  			int num_parents)
> -- 
> 2.7.4
>