linux-kernel - Re: [PATCH] arm64: dts: qcom: add Venus firmware node on Cheza

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1d31b609-9bae-8bbd-0329-f27f59b4533e@linaro.org>
Date:   Wed, 8 Jan 2020 10:31:06 +0200
From:   Stanimir Varbanov <stanimir.varbanov@...aro.org>
To:     Rob Clark <robdclark@...il.com>,
        Stanimir Varbanov <stanimir.varbanov@...aro.org>
Cc:     Alexandre Courbot <acourbot@...omium.org>,
        linux-media@...r.kernel.org,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Vikash Garodia <vgarodia@...eaurora.org>
Subject: Re: [PATCH] arm64: dts: qcom: add Venus firmware node on Cheza



On 1/7/20 7:42 PM, Rob Clark wrote:
> On Tue, Jan 7, 2020 at 6:51 AM Stanimir Varbanov
> <stanimir.varbanov@...aro.org> wrote:
>>
>> Hi Alex,
>>
>> On 1/7/20 4:34 PM, Alexandre Courbot wrote:
>>> Cheza boards require this node to probe, so add it.
>>>
>>> Signed-off-by: Alexandre Courbot <acourbot@...omium.org>
>>> ---
>>>  arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 6 ++++++
>>>  arch/arm64/boot/dts/qcom/sdm845.dtsi       | 2 +-
>>>  2 files changed, 7 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
>>> index 9a4ff57fc877..35ba65cd9822 100644
>>> --- a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
>>> @@ -1279,3 +1279,9 @@ config {
>>>               };
>>>       };
>>>  };
>>> +
>>> +&venus_codec {
>>
>> We have similar patch for sc7180 and call it just "venus". Do you think
>> we should shorten it here too?
>>
>>> +     video-firmware {
>>> +             iommus = <&apps_smmu 0x10b2 0x0>;
>>> +     };
> 
> 
> btw Stan, not sure if you noticed, but Bjorn started adding
> firmware-name properties so we can have different device specific
> subdirectories for signed fw (ie. so one /lib/firmware can work on
> multiple different devices).  I'm just looking at doing the same thing
> for gpu zap fw.  Afaiu the venus fw is also signed, so I guess it
> could benefit from the same treatment?  Not sure if that is something
> you've already talked with Bjorn about?

I have to check does Venus fw is signed with device specific keys or
with something else (like HMAC).

Cc: Vikash for opinion

> 
> BR,
> -R
> 
>>> +};
>>> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>>> index ddb1f23c936f..7b913688cc6d 100644
>>> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>>> @@ -2567,7 +2567,7 @@ usb_2_dwc3: dwc3@...0000 {
>>>                       };
>>>               };
>>>
>>> -             video-codec@...0000 {
>>> +             venus_codec: video-codec@...0000 {
>>>                       compatible = "qcom,sdm845-venus";
>>>                       reg = <0 0x0aa00000 0 0xff000>;
>>>                       interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
>>>
>>
>> --
>> regards,
>> Stan

-- 
regards,
Stan