linux-kernel - [PATCH] locking/percpu-rwsem: Add might

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200108013305.7732-2-dave@stgolabs.net>
Date:   Tue,  7 Jan 2020 17:33:05 -0800
From:   Davidlohr Bueso <dave@...olabs.net>
To:     dave@...olabs.net
Cc:     bigeasy@...utronix.de, bristot@...hat.com, jack@...e.com,
        juri.lelli@...hat.com, linux-kernel@...r.kernel.org,
        longman@...hat.com, mingo@...nel.org, oleg@...hat.com,
        peterz@...radead.org, tglx@...utronix.de, will@...nel.org,
        williams@...hat.com, Davidlohr Bueso <dbueso@...e.de>
Subject: [PATCH] locking/percpu-rwsem: Add might_sleep() for writer locking

We are missing this annotation in percpu_down_write(). Correct
this.

Signed-off-by: Davidlohr Bueso <dbueso@...e.de>
---

Applies against your queue tree.

 kernel/locking/percpu-rwsem.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/locking/percpu-rwsem.c b/kernel/locking/percpu-rwsem.c
index 4cbeeada8d09..08db2abfa00d 100644
--- a/kernel/locking/percpu-rwsem.c
+++ b/kernel/locking/percpu-rwsem.c
@@ -212,6 +212,7 @@ static bool readers_active_check(struct percpu_rw_semaphore *sem)
 
 void percpu_down_write(struct percpu_rw_semaphore *sem)
 {
+	might_sleep();
 	rwsem_acquire(&sem->dep_map, 0, 0, _RET_IP_);
 
 	/* Notify readers to take the slow path. */
-- 
2.16.4