linux-kernel - Re: [resend v1 1/5] block/genhd: Notify udev about capacity change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200108150245.GA10975@lst.de>
Date:   Wed, 8 Jan 2020 16:02:45 +0100
From:   "hch@....de" <hch@....de>
To:     Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>
Cc:     Balbir Singh <sblbir@...zon.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "axboe@...nel.dk" <axboe@...nel.dk>,
        "ssomesh@...zon.com" <ssomesh@...zon.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "hch@....de" <hch@....de>, "mst@...hat.com" <mst@...hat.com>
Subject: Re: [resend v1 1/5] block/genhd: Notify udev about capacity change

On Fri, Jan 03, 2020 at 06:16:39AM +0000, Chaitanya Kulkarni wrote:
> Since disk_set_capacity(() is on the same line as set_capacity()
> we should follow the same convention, which is :-
> 
> 1. Avoid exporting symbol.
> 2. Mark new function in-line.
> 
> Unless there is a very specific reason for breaking the pattern.

Why would we mark it as inline?  It isn't by any means in the fast
path, and there are no easy opportunities for constant propagation,
so the only thing that would do is increase the code size.