linux-kernel - Re: [PATCH] tracing: Initialize ret in syscall_enter_define

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200108150311.GA2827@hirez.programming.kicks-ass.net>
Date:   Wed, 8 Jan 2020 16:03:11 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>, Qian Cai <cai@....pw>
Subject: Re: [PATCH] tracing: Initialize ret in syscall_enter_define_fields()

On Wed, Jan 08, 2020 at 08:57:55AM -0500, Steven Rostedt wrote:
> 
> From: "Steven Rostedt (VMware)" <rostedt@...dmis.org>
> 
> If syscall_enter_define_fields() is called on a system call with no
> arguments, the return code variable "ret" will never get initialized.
> Initialize it to zero.
> 
> Link: https://lore.kernel.org/r/0FA8C6E3-D9F5-416D-A1B0-5E4CD583A101@lca.pw
> Fixes: 04ae87a52074e ("ftrace: Rework event_create_dir()")
> Reported-by: Qian Cai <cai@....pw>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

Thanks Steve!