linux-kernel - Re: [PATCH 1/1] media: dvb_dummy_tuner: implement driver skeleton

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ebec2bb5-8db0-76fe-9c66-0316c1800f7c@gmail.com>
Date:   Thu, 9 Jan 2020 18:00:01 -0300
From:   "Daniel W. S. Almeida" <dwlsalmeida@...il.com>
To:     Shuah Khan <skhan@...uxfoundation.org>, mchehab@...nel.org,
        sean@...s.org, tglx@...utronix.de, gregkh@...uxfoundation.org
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH 1/1] media: dvb_dummy_tuner: implement driver skeleton

Hi Shuah, thank you for you input!


>
> Looks like there is more code to be added to register/unregister 

Just to be clear, attach() is missing, but register / unregister belong 
in the bridge driver. Is this correct?


>
> Please add more detail here on what this driver does. What this
> driver is used for and so on.
>
>
> Samehere. Give more details on what this driver does. Add enough detail
> to help users decide why they should enable it or not. 
>
> General practice is the following.
>
> Copyright (c) 2020 Daniel W. S. Almeida <dwlsalmeida@...il.com>

> Please add details about the driver similar to the .c file. 

OK.


Thanks

- Daniel