linux-kernel - Re: [PATCH v2] x86/boot/KASLR: Fix unused variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 09 Jan 2020 22:00:05 +0100
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Zhenzhong Duan <zhenzhong.duan@...il.com>,
        linux-kernel@...r.kernel.org
Cc:     x86@...nel.org, Zhenzhong Duan <zhenzhong.duan@...il.com>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...e.de>,
        "H. Peter Anvin" <hpa@...or.com>,
        Chao Fan <fanc.fnst@...fujitsu.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
Subject: Re: [PATCH v2] x86/boot/KASLR: Fix unused variable warning

Zhenzhong Duan <zhenzhong.duan@...il.com> writes:

> Local variable 'i' is referenced only when CONFIG_MEMORY_HOTREMOVE and
> CONFIG_ACPI are defined, but definition of variable 'i' is out of guard.
> If any of the two macros is undefined, below warning triggers during
> build, fix it by moving 'i' in the guard.
>
> arch/x86/boot/compressed/kaslr.c:698:6: warning: unused variable ‘i’ [-Wunused-variable]
>
> Also use true/false instead of 1/0 for boolean return.

No. This is not the scope of the unused variable issue. This want's to
be a separate patch.

Thanks,

        tglx