linux-kernel - Re: [resend v1 4/5] drivers/nvme/host/core.c: Convert to use disk_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cc8dddbcad70453efad665dc19787803ec48fdd6.camel@redhat.com>
Date:   Thu, 09 Jan 2020 08:12:27 -0500
From:   "Ewan D. Milne" <emilne@...hat.com>
To:     "Martin K. Petersen" <martin.petersen@...cle.com>,
        "hch@....de" <hch@....de>
Cc:     "axboe@...nel.dk" <axboe@...nel.dk>,
        "Chaitanya.Kulkarni@....com" <Chaitanya.Kulkarni@....com>,
        "mst@...hat.com" <mst@...hat.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "Sangaraju, Someswarudu" <ssomesh@...zon.com>,
        "Singh, Balbir" <sblbir@...zon.com>
Subject: Re: [resend v1 4/5] drivers/nvme/host/core.c: Convert to use
 disk_set_capacity

On Wed, 2020-01-08 at 22:33 -0500, Martin K. Petersen wrote:
> Christoph,
> 
> > > The expected behaviour is not clear, but the functionality is not
> > > broken, user space should be able to deal with a resize event where
> > > the previous capacity == new capacity IMHO.
> > 
> > I think it makes sense to not bother with a notification unless there
> > is an actual change.
> 
> I agree.
> 

Yes, absolutely.