linux-kernel - Re: [resend v1 4/5] drivers/nvme/host/core.c: Convert to use disk_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1k161xq1f.fsf@oracle.com>
Date:   Wed, 08 Jan 2020 22:33:00 -0500
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     "hch\@lst.de" <hch@....de>
Cc:     "Singh\, Balbir" <sblbir@...zon.com>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
        "Chaitanya.Kulkarni\@wdc.com" <Chaitanya.Kulkarni@....com>,
        "linux-block\@vger.kernel.org" <linux-block@...r.kernel.org>,
        "linux-nvme\@lists.infradead.org" <linux-nvme@...ts.infradead.org>,
        "jejb\@linux.ibm.com" <jejb@...ux.ibm.com>,
        "mst\@redhat.com" <mst@...hat.com>,
        "axboe\@kernel.dk" <axboe@...nel.dk>,
        "Sangaraju\, Someswarudu" <ssomesh@...zon.com>
Subject: Re: [resend v1 4/5] drivers/nvme/host/core.c: Convert to use disk_set_capacity


Christoph,

>> The expected behaviour is not clear, but the functionality is not
>> broken, user space should be able to deal with a resize event where
>> the previous capacity == new capacity IMHO.
>
> I think it makes sense to not bother with a notification unless there
> is an actual change.

I agree.

-- 
Martin K. Petersen	Oracle Linux Engineering