[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200109175318.73ab8bd7@xps13>
Date: Thu, 9 Jan 2020 17:53:18 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Mason Yang <masonccyang@...c.com.tw>
Cc: richard@....at, marek.vasut@...il.com, dwmw2@...radead.org,
bbrezillon@...nel.org, computersforpeace@...il.com,
vigneshr@...com, juliensu@...c.com.tw,
linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org
Subject: Re: [PATCH v2 3/4] mtd: rawnand: Add support manufacturer specific
suspend/resume operation
Hi Mason,
Mason Yang <masonccyang@...c.com.tw> wrote on Mon, 28 Oct 2019 17:55:26
+0800:
> Patch nand_suspend() & nand_resume() for manufacturer specific
> suspend/resume operation.
>
> Signed-off-by: Mason Yang <masonccyang@...c.com.tw>
> ---
> drivers/mtd/nand/raw/nand_base.c | 9 +++++++--
> include/linux/mtd/rawnand.h | 2 ++
> 2 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
> index 5e318ff..2a9c5bb 100644
> --- a/drivers/mtd/nand/raw/nand_base.c
> +++ b/drivers/mtd/nand/raw/nand_base.c
> @@ -4323,6 +4323,8 @@ static int nand_suspend(struct mtd_info *mtd)
> struct nand_chip *chip = mtd_to_nand(mtd);
>
> mutex_lock(&chip->lock);
> + if (chip->_suspend)
> + chip->_suspend(chip);
Return value should be checked!
> chip->suspended = 1;
> mutex_unlock(&chip->lock);
>
> @@ -4338,11 +4340,14 @@ static void nand_resume(struct mtd_info *mtd)
> struct nand_chip *chip = mtd_to_nand(mtd);
>
> mutex_lock(&chip->lock);
> - if (chip->suspended)
> + if (chip->suspended) {
> + if (chip->_resume)
> + chip->_resume(chip);
> chip->suspended = 0;
> - else
> + } else {
> pr_err("%s called for a chip which is not in suspended state\n",
> __func__);
> + }
> mutex_unlock(&chip->lock);
> }
>
> diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h
> index 2430ecd..6b14041 100644
> --- a/include/linux/mtd/rawnand.h
> +++ b/include/linux/mtd/rawnand.h
> @@ -1117,6 +1117,8 @@ struct nand_chip {
>
> struct mutex lock;
> unsigned int suspended : 1;
> + int (*_suspend)(struct nand_chip *chip);
> + void (*_resume)(struct nand_chip *chip);
Please don't forget the kdoc!
>
> uint8_t *oob_poi;
> struct nand_controller *controller;
With this fixed,
Reviewed-by: Miquel Raynal <miquel.raynal@...tlin.com>
Thanks,
Miquèl
Powered by blists - more mailing lists