linux-kernel - Re: [PATCH] lib/list_sort: fix function type mismatches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <202001110830.00B8USV0024843@sdf.org>
Date:   Sat, 11 Jan 2020 08:30:28 GMT
From:   George Spelvin <lkml@....org>
To:     samitolvanen@...gle.com
Cc:     akpm@...ux-foundation.org, andriy.shevchenko@...ux.intel.com,
        keescook@...omium.org, linux-kernel@...r.kernel.org,
        linux@...musvillemoes.dk, lkml@....org, mchehab+samsung@...nel.org,
        st5pub@...dex.ru
Subject: Re: [PATCH] lib/list_sort: fix function type mismatches

>  typedef int __attribute__((nonnull(2,3))) (*cmp_func)(void *,
> -		struct list_head const *, struct list_head const *);
> +		struct list_head *, struct list_head *);

I'd prefer to leave the const there for documentation.
Does anyone object to fixing it in the other direction by *adding*
const to all the call sites?

Andy Shevchenko posted a patch last 7 October that did that.
<20191007135656.37734-1-andriy.shevchenko@...ux.intel.com>

(You could also try taking a second look at why __pure doesn't work,
per AKPM's message of 16 April
<20190416154522.65aaa348161fc581181b56d9@...ux-foundation.org>)