linux-kernel - Re: [PATCH] lib/list_sort: fix function type mismatches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VcWryeiN_bwJjFk=RO1k+H5q7h6_3oGArf1XzF-6dNxKg@mail.gmail.com>
Date:   Sat, 11 Jan 2020 12:35:39 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     George Spelvin <lkml@....org>
Cc:     samitolvanen@...gle.com, Andrew Morton <akpm@...ux-foundation.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Kees Cook <keescook@...omium.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
        Andrey Abramov <st5pub@...dex.ru>
Subject: Re: [PATCH] lib/list_sort: fix function type mismatches

On Sat, Jan 11, 2020 at 10:31 AM George Spelvin <lkml@....org> wrote:
>
> >  typedef int __attribute__((nonnull(2,3))) (*cmp_func)(void *,
> > -             struct list_head const *, struct list_head const *);
> > +             struct list_head *, struct list_head *);
>
> I'd prefer to leave the const there for documentation.

Not only. It's useful to show that we are not going to change those parameters.

> Does anyone object to fixing it in the other direction by *adding*
> const to all the call sites?

Agree.
Actually we have cmp_r_funct_t which might be used here (I didn't
check for the possibility, though).

>
> Andy Shevchenko posted a patch last 7 October that did that.
> <20191007135656.37734-1-andriy.shevchenko@...ux.intel.com>
>
> (You could also try taking a second look at why __pure doesn't work,
> per AKPM's message of 16 April
> <20190416154522.65aaa348161fc581181b56d9@...ux-foundation.org>)

Hint: When you post Message-Id you may prefix them with
https://lore.kernel.org/r/ which makes search a bit more convenient
and faster.


-- 
With Best Regards,
Andy Shevchenko