linux-kernel - Re: [PATCH -next] hwmon: (w83627ehf) Remove set but not used variable 'fan4min'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 10 Jan 2020 19:44:39 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     Jean Delvare <jdelvare@...e.com>,
        "Dr . David Alan Gilbert" <linux@...blig.org>,
        linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH -next] hwmon: (w83627ehf) Remove set but not used
 variable 'fan4min'

On Wed, Jan 08, 2020 at 03:45:14AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/hwmon/w83627ehf.c: In function 'w83627ehf_check_fan_inputs':
> drivers/hwmon/w83627ehf.c:1296:24: warning:
>  variable 'fan4min' set but not used [-Wunused-but-set-variable]
> 
> commit 62000264cfa8 ("hwmon: (w83627ehf) remove nct6775 and nct6776 support")
> left behind this unused variable.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/w83627ehf.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c
> index 5a7239eb1c15..7ffadc2da57b 100644
> --- a/drivers/hwmon/w83627ehf.c
> +++ b/drivers/hwmon/w83627ehf.c
> @@ -1293,7 +1293,7 @@ static void
>  w83627ehf_check_fan_inputs(const struct w83627ehf_sio_data *sio_data,
>  			   struct w83627ehf_data *data)
>  {
> -	int fan3pin, fan4pin, fan4min, fan5pin, regval;
> +	int fan3pin, fan4pin, fan5pin, regval;
>  
>  	/* The W83627UHG is simple, only two fan inputs, no config */
>  	if (sio_data->kind == w83627uhg) {
> @@ -1307,12 +1307,10 @@ w83627ehf_check_fan_inputs(const struct w83627ehf_sio_data *sio_data,
>  		fan3pin = 1;
>  		fan4pin = superio_inb(sio_data->sioreg, 0x27) & 0x40;
>  		fan5pin = superio_inb(sio_data->sioreg, 0x27) & 0x20;
> -		fan4min = fan4pin;
>  	} else {
>  		fan3pin = 1;
>  		fan4pin = !(superio_inb(sio_data->sioreg, 0x29) & 0x06);
>  		fan5pin = !(superio_inb(sio_data->sioreg, 0x24) & 0x02);
> -		fan4min = fan4pin;
>  	}
>  
>  	data->has_fan = data->has_fan_min = 0x03; /* fan1 and fan2 */