linux-kernel - Re: [PATCH] hwmon: (pmbus/ibm-cffps) Prevent writing on_off

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200111034541.GA5609@roeck-us.net>
Date:   Fri, 10 Jan 2020 19:45:41 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Eddie James <eajames@...ux.ibm.com>
Cc:     linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
        jdelvare@...e.com, dan.carpenter@...cle.com
Subject: Re: [PATCH] hwmon: (pmbus/ibm-cffps) Prevent writing on_off_config
 with bad data

On Tue, Jan 07, 2020 at 09:40:40AM -0600, Eddie James wrote:
> If the user write parameters resulted in no bytes being written to the
> temporary buffer, then ON_OFF_CONFIG will be written with uninitialized
> data. Prevent this by bailing out in this case.
> 
> Signed-off-by: Eddie James <eajames@...ux.ibm.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/pmbus/ibm-cffps.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/pmbus/ibm-cffps.c b/drivers/hwmon/pmbus/ibm-cffps.c
> index 1c91ee1f9926..3795fe55b84f 100644
> --- a/drivers/hwmon/pmbus/ibm-cffps.c
> +++ b/drivers/hwmon/pmbus/ibm-cffps.c
> @@ -250,7 +250,7 @@ static ssize_t ibm_cffps_debugfs_write(struct file *file,
>  		pmbus_set_page(psu->client, 0);
>  
>  		rc = simple_write_to_buffer(&data, 1, ppos, buf, count);
> -		if (rc < 0)
> +		if (rc <= 0)
>  			return rc;
>  
>  		rc = i2c_smbus_write_byte_data(psu->client,