linux-kernel - Re: [PATCH] staging: exfat: make staging/exfat and fs/exfat mutually exclusive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200111175611.GA422540@kroah.com>
Date:   Sat, 11 Jan 2020 18:56:11 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Namjae Jeon <linkinjeon@...il.com>
Cc:     valdis.kletnieks@...edu, devel@...verdev.osuosl.org,
        Namjae Jeon <namjae.jeon@...sung.com>, amir73il@...il.com,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] staging: exfat: make staging/exfat and fs/exfat mutually
 exclusive

On Sat, Jan 11, 2020 at 09:14:19PM +0900, Namjae Jeon wrote:
> From: Namjae Jeon <namjae.jeon@...sung.com>
> 
> Make staging/exfat and fs/exfat mutually exclusive to select the one
> between two same filesystem.
> 
> Suggested-by: Amir Goldstein <amir73il@...il.com>
> Signed-off-by: Namjae Jeon <namjae.jeon@...sung.com>
> ---
>  drivers/staging/exfat/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/exfat/Kconfig b/drivers/staging/exfat/Kconfig
> index 292a19dfcaf5..9a0fccec65d9 100644
> --- a/drivers/staging/exfat/Kconfig
> +++ b/drivers/staging/exfat/Kconfig
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0
>  config STAGING_EXFAT_FS
>  	tristate "exFAT fs support"
> -	depends on BLOCK
> +	depends on BLOCK && !EXFAT_FS

There is no such symbol in the kernel tree, so this isn't going to do
anything :(

When/if EXFAT_FS does show up, I will be glad to add this.  Or better
yet, just have this as part of the "real" exfat patchset, that would
make the most sense, right?

thanks,

greg k-h