linux-kernel - Re: [PATCH v4] tpm: Add tpm_version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 13 Jan 2020 02:08:24 +0200
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     linux-kernel@...r.kernel.org, Mimi Zohar <zohar@...ux.ibm.com>,
        Peter Huewe <peterhuewe@....de>,
        Jason Gunthorpe <jgg@...pe.ca>, linux-integrity@...r.kernel.org
Subject: Re: [PATCH v4] tpm: Add tpm_version_major sysfs file

On Thu, Jan 09, 2020 at 02:49:35PM -0700, Jerry Snitselaar wrote:
> On Sat Nov 30 19, Jarkko Sakkinen wrote:
> > On Wed, Nov 27, 2019 at 06:08:26PM -0700, Jerry Snitselaar wrote:
> > > On Wed Oct 30 19, Jerry Snitselaar wrote:
> > > > Easily determining what TCG version a tpm device implements
> > > > has been a pain point for userspace for a long time, so
> > > > add a sysfs file to report the TCG major version of a tpm device.
> > > >
> > > > Also add an entry to Documentation/ABI/stable/sysfs-class-tpm
> > > > describing the new file.
> > > >
> > > > Cc: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
> > > > Cc: Mimi Zohar <zohar@...ux.ibm.com>
> > > > Cc: Peter Huewe <peterhuewe@....de>
> > > > Cc: Jason Gunthorpe <jgg@...pe.ca>
> > > > Cc: linux-integrity@...r.kernel.org
> > > > Signed-off-by: Jerry Snitselaar <jsnitsel@...hat.com>
> > > > ---
> > > > v4: - Change file name to tpm_version_major
> > > >    - Actually display just the major version.
> > > >    - change structs to tpm1_* & tpm2_*
> > > >      instead of tpm12_* tpm20_*.
> > > > v3: - Change file name to version_major.
> > > > v2: - Fix TCG usage in commit message.
> > > >    - Add entry to sysfs-class-tpm in Documentation/ABI/stable
> > > >
> > > > Documentation/ABI/stable/sysfs-class-tpm | 11 ++++++++
> > > > drivers/char/tpm/tpm-sysfs.c             | 34 +++++++++++++++++++-----
> > > > 2 files changed, 38 insertions(+), 7 deletions(-)
> > > >
> > > 
> > > Anyone else have feedback?
> > 
> > I can apply this after the issues on hand have been sorted out.
> > 
> > /Jarkko
> > 
> 
> Hi Jarkko,
> 
> Will this get queued up for 5.6?

Thanks for reminding and apologies for forgetting this!

I'll see what I can do.

/Jarkko