linux-kernel - Re: [PATCH next] ASoC: atmel: fix build error with CONFIG_SND_ATMEL_SOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <50064e1e-8295-7ddf-6860-c4b798127dd6@microchip.com>
Date:   Mon, 13 Jan 2020 16:21:39 +0000
From:   <Codrin.Ciubotariu@...rochip.com>
To:     <chenzhou10@...wei.com>, <broonie@...nel.org>, <perex@...ex.cz>,
        <tiwai@...e.com>
CC:     <linux-kernel@...r.kernel.org>, <alsa-devel@...a-project.org>,
        <arnd@...db.de>
Subject: Re: [PATCH next] ASoC: atmel: fix build error with
 CONFIG_SND_ATMEL_SOC_DMA=m

On 13.01.2020 15:32, Chen Zhou wrote:
> If CONFIG_SND_ATMEL_SOC_DMA=m, build error:
> 
> sound/soc/atmel/atmel_ssc_dai.o: In function `atmel_ssc_set_audio':
> (.text+0x7cd): undefined reference to `atmel_pcm_dma_platform_register'
> 
> Function atmel_pcm_dma_platform_register is defined under
> CONFIG SND_ATMEL_SOC_DMA, so select SND_ATMEL_SOC_DMA in
> CONFIG SND_ATMEL_SOC_SSC, same to CONFIG_SND_ATMEL_SOC_PDC.

Arnd sent a more complete patch for this issue:
https://lkml.org/lkml/2019/10/1/620

It wasn't merged due to some integration issues. Could you please try it 
and let us know if it fixes your issue?

Thanks and best regards,
Codrin

> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Chen Zhou <chenzhou10@...wei.com>
> ---
>   sound/soc/atmel/Kconfig | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig
> index f118c22..d1dc8e6 100644
> --- a/sound/soc/atmel/Kconfig
> +++ b/sound/soc/atmel/Kconfig
> @@ -19,6 +19,8 @@ config SND_ATMEL_SOC_DMA
> 
>   config SND_ATMEL_SOC_SSC
>          tristate
> +       select SND_ATMEL_SOC_DMA
> +       select SND_ATMEL_SOC_PDC
> 
>   config SND_ATMEL_SOC_SSC_PDC
>          tristate "SoC PCM DAI support for AT91 SSC controller using PDC"
> --
> 2.7.4
>