linux-kernel - Re: [PATCH v3] spi: fsl: simplify error path in of_fsl_spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200114165739.GC3897@sirena.org.uk>
Date:   Tue, 14 Jan 2020 16:57:39 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Joakim Tjernlund <Joakim.Tjernlund@...inera.com>
Cc:     "christophe.leroy@....fr" <christophe.leroy@....fr>,
        "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "lkp@...el.com" <lkp@...el.com>,
        "geert@...ux-m68k.org" <geert@...ux-m68k.org>
Subject: Re: [PATCH v3] spi: fsl: simplify error path in of_fsl_spi_probe()

On Tue, Jan 14, 2020 at 04:26:18PM +0000, Joakim Tjernlund wrote:

> Don't you need to "undo" ioremap, irq etc. in case of later errors?

Better, convert to devm_ 

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)