lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 14 Jan 2020 15:10:16 +0800 From: Zenghui Yu <yuzenghui@...wei.com> To: Auger Eric <eric.auger@...hat.com>, <maz@...nel.org> CC: <andre.przywara@....com>, <linux-arm-kernel@...ts.infradead.org>, <kvmarm@...ts.cs.columbia.edu>, <linux-kernel@...r.kernel.org>, <wanghaibin.wang@...wei.com> Subject: Re: [PATCH] KVM: arm/arm64: vgic-its: Check hopefully the last DISCARD command error Hi Eric, On 2020/1/10 16:37, Auger Eric wrote: > Hi Zenghui, > > On 12/25/19 2:30 PM, Zenghui Yu wrote: >> DISCARD command error occurs if any of the following apply: >> >> - [ ... (those which we have already handled) ] > nit: I would remove the above and simply say the discard is supposed to > fail if the collection is not mapped to any target redistributor. If an > ITE exists then the ite->collection is non NULL. I think this is not always true. Let's talk about the following scenario (a bit insane, though): 1. First map a LPI to an unmapped Collection, then ite->collection is non NULL and its target_addr is COLLECTION_NOT_MAPPED. 2. Then issue MAPC and unMAPC(V=0) commands on this Collection, the ite->collection will be NULL, see vgic_its_free_collection(). Discard the LPI mapping after "1" or "2", we will both encounter the unmapped collection command error. > What needs to be checked is its_is_collection_mapped(). > > By the way update_affinity_collection() also tests ite->collection. I > think this is useless or do I miss something? Yeah, I agree. We managed to invoke update_affinity_collection(,, coll), ensure that the 'coll' can _not_ be NULL. So '!ite->collection' is already a subcase of 'coll != ite->collection'. We can safely get rid of it. > > Reviewed-by: Eric Auger <eric.auger@...hat.com> > Thanks for that. I'll change the commit message with your suggestion and add your R-b in v2. Thanks, Zenghui
Powered by blists - more mailing lists