linux-kernel - regulator: mpq7920: Some inconsistencies in current driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Jan 2020 20:49:16 +0800
From:   Axel Lin <axel.lin@...ics.com>
To:     Saravanan Sekar <sravanhome@...il.com>
Cc:     Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: regulator: mpq7920: Some inconsistencies in current driver

Hi Saravanan,

There are a few inconsistencies in current driver:
I don't have the datasheet, so I'm not 100% sure.
Maybe you can help check it.

1. It's unlikely MPQ7920_LDO1_REG_B and MPQ7920_REG_CTL0 have the same address.
   I think this needs double check.

2. The MPQ7920_DISCHARGE_ON seems wrong because it does not match
MPQ7920_MASK_DISCHARGE.
   I guess MPQ7920_DISCHARGE_ON should be BIT(5).

3. The MPQ7920_MASK_BUCK_ILIM seems wrong. I guess it should be 0xC0.

4. Not sure why define both MPQ7920_REG_REGULATOR_EN1 and
MPQ7920_REG_REGULATOR_EN.

Regards,
Axel