linux-kernel - Re: [PATCH] mm/vmscan: remove prefetch_prev_lru

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <F5F5B735-2BEA-4B9D-8939-B24B9D9AA940@lca.pw>
Date:   Wed, 15 Jan 2020 13:27:57 -0500
From:   Qian Cai <cai@....pw>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Alex Shi <alex.shi@...ux.alibaba.com>,
        Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/vmscan: remove prefetch_prev_lru_page



> On Jan 15, 2020, at 3:29 AM, Christoph Hellwig <hch@...radead.org> wrote:
> 
> On Tue, Jan 14, 2020 at 08:46:21AM -0500, Qian Cai wrote:
>> 
>> 
>>> On Jan 14, 2020, at 7:55 AM, Alex Shi <alex.shi@...ux.alibaba.com> wrote:
>>> 
>>> This macro are never used in git history. So better to remove.
>> 
>> When removing unused thingy, it is important to figure out which commit introduced it in the first place and Cc the relevant people in that commit.
> 
> No, it isn't.  It is at best nice to have, but for a trivial macro
> really doesn't matter.

A more of personal taste what the trivial macro is. I’d rather be on the caution side
when removing code especially nowaday developers may not even compile
test the patch properly given how many arches we have here which will only waste
time on other people when things goes wrong.