linux-kernel - Re: [PATCH] mm/vmscan: remove prefetch_prev_lru

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <B6E75D9E-E9A2-4078-A89A-267310467B0A@lca.pw>
Date:   Thu, 16 Jan 2020 07:26:23 -0500
From:   Qian Cai <cai@....pw>
To:     Alex Shi <alex.shi@...ux.alibaba.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/vmscan: remove prefetch_prev_lru_page



> On Jan 14, 2020, at 9:33 PM, Alex Shi <alex.shi@...ux.alibaba.com> wrote:
> 
> 
> 
>> 在 2020/1/14 下午9:46, Qian Cai 写道:
>> 
>> 
>>>> On Jan 14, 2020, at 7:55 AM, Alex Shi <alex.shi@...ux.alibaba.com> wrote:
>>> 
>>> This macro are never used in git history. So better to remove.
>> 
>> When removing unused thingy, it is important to figure out which commit introduced it in the first place and Cc the relevant people in that commit.
>> 
> 
> Thanks fore reminder, Qian!
> 
> This macro was introduced in 1da177e4c3f4 Linux-2.6.12-rc2, no author or commiter could be found.

Looks a bit deeper for this, and I am not sure if it is necessary to remove it especially this does not cause any complication warning noise, because the macro looks like a part of API design to have a pair of both read and write version, even though only the write version is used at the moment.

In theory,  there could be users for the read version in the future, and then it needs to be added back.