linux-kernel - Re: [PATCH v2] pinctrl/rockchip: splite soc data to separated driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c4ec95a7-aaf1-2331-352f-2def319a1c7d@rock-chips.com>
Date:   Thu, 16 Jan 2020 11:44:44 +0800
From:   Kever Yang <kever.yang@...k-chips.com>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Jianqun Xu <jay.xu@...k-chips.com>,
        Heiko Stübner <heiko@...ech.de>
Cc:     David Wu <david.wu@...k-chips.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        Peter Robinson <pbrobinson@...il.com>,
        Vagrant Cascadian <vagrant@...ian.org>, afaerber@...e.de,
        Tao Huang <huangtao@...k-chips.com>
Subject: Re: [PATCH v2] pinctrl/rockchip: splite soc data to separated driver


On 2020/1/15 下午8:51, Linus Walleij wrote:
> On Mon, Jan 13, 2020 at 2:16 AM Jianqun Xu <jay.xu@...k-chips.com> wrote:
>
>> * Decrease codes of pinctrl-rockchip.c from 4,000 lines to 2000 by
>> separating soc data to a new file.
>>
>> * Move rockchip pinctrl related struct definations to a head file.
>>
>> * Keep legency pinctrl-rockchip.c under driver/pinctrl but not to
>> compile it, conveniently for reviewers.
>>
>> Signed-off-by: Jianqun Xu <jay.xu@...k-chips.com>
> This patch looks good, two things are missing:
>
> - Review from Heiko
>
> - A change to MAINTAINERS so that the file pattern still
>    matches
>
> Should someone from Rockchip also sign up as comaintainer
> for this driver by the way? (Though the people at Rockchip
> posting patches for this seem to change a bit.)


The kernel Image size is keep growing, this patch can help reduce the 
size of

kernel image for one SoC, and this is what we have done in U-Boot mainline.

And for distribution kernel who need to cover all the SoCs with one 
kernel image,

need to update the defconfig.

The patch looks good to me,

Reviewed-by: Kever Yang <kever.yang@...k-chips.com>

Thanks,
- Kever


>
> Yours,
> Linus Walleij
>
>